Follow-up to 700913, since I missed it. If persistence is set to -1, the doorhanger never closes automatically, but must be closed by the user.

When I was writing this patch I realized that my previous patch was actually buggy - there was no way to override the persistence or timeout options, even in cases where you always want to remove the doorhanger, like the onClick handler for the buttons. I modeled my fix after removeTransientNotifications in notification.xml, so now there's a separate remove method to handle this special location change case.

Comment on attachment 574422 [details] [diff] [review] patch > public boolean shouldRemove() { >- if (mPersistence > 0) { >+ if (mPersistence != 0) { Maybe add a comment about -1 being a legal value meaning never automatically close?

(In reply to Mark Finkle (:mfinkle) from comment #2) > Comment on attachment 574422 [details] [diff] [review] [diff] [details] [review] > patch > > > public boolean shouldRemove() { > >- if (mPersistence > 0) { > >+ if (mPersistence != 0) { > > Maybe add a comment about -1 being a legal value meaning never automatically > close? Good call - the toolkit code didn't have that comment, and that's why I copied it wrong! :)