Closed
Bug 702386
Opened 13 years ago
Closed 13 years ago
Support setting persistence to -1 for doorhangers
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(firefox11 fixed, fennec11+)
RESOLVED
FIXED
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Follow-up to 700913, since I missed it. If persistence is set to -1, the doorhanger never closes automatically, but must be closed by the user.
Assignee | ||
Comment 1•13 years ago
|
||
When I was writing this patch I realized that my previous patch was actually buggy - there was no way to override the persistence or timeout options, even in cases where you always want to remove the doorhanger, like the onClick handler for the buttons. I modeled my fix after removeTransientNotifications in notification.xml, so now there's a separate remove method to handle this special location change case.
Attachment #574422 -
Flags: review?(mark.finkle)
Updated•13 years ago
|
Priority: -- → P2
Updated•13 years ago
|
Attachment #574422 -
Flags: review?(mark.finkle) → review+
Comment 2•13 years ago
|
||
Comment on attachment 574422 [details] [diff] [review]
patch
> public boolean shouldRemove() {
>- if (mPersistence > 0) {
>+ if (mPersistence != 0) {
Maybe add a comment about -1 being a legal value meaning never automatically close?
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Mark Finkle (:mfinkle) from comment #2)
> Comment on attachment 574422 [details] [diff] [review] [diff] [details] [review]
> patch
>
> > public boolean shouldRemove() {
> >- if (mPersistence > 0) {
> >+ if (mPersistence != 0) {
>
> Maybe add a comment about -1 being a legal value meaning never automatically
> close?
Good call - the toolkit code didn't have that comment, and that's why I copied it wrong! :)
Assignee | ||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
tracking-fennec: --- → 11+
Updated•13 years ago
|
status-firefox11:
--- → fixed
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•