Closed Bug 702519 Opened 13 years ago Closed 7 years ago

Make WeaveCrypto obey NSS usage rules

Categories

(Firefox :: Sync, defect)

Product:
Firefox
Component:
Sync
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: rnewman, Unassigned)

References

(Depends on 1 open bug)

Details

(Whiteboard: [sync:crypto][closeme-sync.next])

Follow-on from Bug 696551. > WeaveCrypto doesn't appear to implement any shutdown logic, but holds on to > ctypes references to NSS functions. Is that another lead? Yes, let's file another bug for that. Basically, the rule is that before you use any NSS function, you must: 1. Acquire the NSS shutdown prevention lock 2. check that NSS hasn't been shut down yet 3. do_GetService(nsINSSComponent) and ensure that it returns a non-NULL reference, and hold that reference (even if you don't use anything from that interface). 4. make your NSS calls.
Depends on: 743070
Priority: P3 → --
Whiteboard: [sync:crypto][closeme-sync.next]
WeaveCrypto is now backed up by SubtleCrypto (bug 1234305).
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
Component: Firefox Sync: Crypto → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.