Closed
Bug 703079
Opened 13 years ago
Closed 13 years ago
Always dispatch mozfullscreenchange to owning document
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
(Whiteboard: [qa?])
Attachments
(1 file)
(deleted),
patch
|
bzbarsky
:
review+
christian
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
The W3 draft spec has changed so that the "fullscreenchange" event is now always dispatched to the document, rather than to the full-screen element upon entering and the document upon exiting from full-screen. We think this is sensible since your listener needs to be on the document to catch both cases anyway, so we should make this change in Firefox 10 so we get this right from the start.
Updated•13 years ago
|
tracking-firefox10:
--- → ?
Assignee | ||
Comment 1•13 years ago
|
||
Always dispatch mozfullscreenchange to owning document to match recent changes to W3 draft spec.
Attachment #575370 -
Flags: review?(bzbarsky)
Comment 2•13 years ago
|
||
Comment on attachment 575370 [details] [diff] [review]
Patch: Always dispatch mozfullscreenchange to owning document
r=me
Attachment #575370 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 3•13 years ago
|
||
status-firefox10:
--- → affected
status-firefox11:
--- → affected
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Comment 5•13 years ago
|
||
Could you please update the mozfullscreenchange handler in browser.js? Specifically this part:
let targetDoc = event.target.ownerDocument ? event.target.ownerDocument : event.target;
Assignee | ||
Comment 6•13 years ago
|
||
Comment on attachment 575370 [details] [diff] [review]
Patch: Always dispatch mozfullscreenchange to owning document
It would be good if we can land this on Aurora since it changes the target of the "you've entered/left full-screen" event, and we'd like to ship the full-screen API in Firefox 10 as close to its final state as possible.
Attachment #575370 -
Flags: approval-mozilla-aurora?
Attachment #575370 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 7•13 years ago
|
||
tracking-firefox10:
? → ---
Target Milestone: mozilla11 → mozilla10
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #8)
> Is this something QA can verify?
bump
You need to log in
before you can comment on or make changes to this bug.
Description
•