Closed Bug 703079 Opened 13 years ago Closed 13 years ago

Always dispatch mozfullscreenchange to owning document

Categories

(Core :: DOM: Core & HTML, defect)

10 Branch
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10
Tracking Status
firefox10 --- fixed
firefox11 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

(Whiteboard: [qa?])

Attachments

(1 file)

The W3 draft spec has changed so that the "fullscreenchange" event is now always dispatched to the document, rather than to the full-screen element upon entering and the document upon exiting from full-screen. We think this is sensible since your listener needs to be on the document to catch both cases anyway, so we should make this change in Firefox 10 so we get this right from the start.
Always dispatch mozfullscreenchange to owning document to match recent changes to W3 draft spec.
Attachment #575370 - Flags: review?(bzbarsky)
Comment on attachment 575370 [details] [diff] [review] Patch: Always dispatch mozfullscreenchange to owning document r=me
Attachment #575370 - Flags: review?(bzbarsky) → review+
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla11
Could you please update the mozfullscreenchange handler in browser.js? Specifically this part: let targetDoc = event.target.ownerDocument ? event.target.ownerDocument : event.target;
Depends on: 704011
Comment on attachment 575370 [details] [diff] [review] Patch: Always dispatch mozfullscreenchange to owning document It would be good if we can land this on Aurora since it changes the target of the "you've entered/left full-screen" event, and we'd like to ship the full-screen API in Firefox 10 as close to its final state as possible.
Attachment #575370 - Flags: approval-mozilla-aurora?
Attachment #575370 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Is this something QA can verify?
Whiteboard: [qa?]
(In reply to Anthony Hughes, Mozilla QA (irc: ashughes) from comment #8) > Is this something QA can verify? bump
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: