Closed
Bug 703667
Opened 13 years ago
Closed 13 years ago
Intermittent test failures in test_breakpoint-01.js
Categories
(DevTools :: Debugger, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: past, Assigned: past)
References
Details
Attachments
(1 file)
(deleted),
patch
|
dcamp
:
review+
rcampbell
:
review+
|
Details | Diff | Splinter Review |
From the try run at: https://tbpl.mozilla.org/?tree=Try&rev=202c0d9b0cdb
TEST-PASS | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_nativewrappers.js | test passed (time: 94.000ms)
TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_eval-01.js | running test ...
TEST-PASS | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_eval-01.js | test passed (time: 98.000ms)
TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_eval-02.js | running test ...
TEST-PASS | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_eval-02.js | test passed (time: 99.000ms)
TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_eval-03.js | running test ...
TEST-PASS | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_eval-03.js | test passed (time: 97.000ms)
TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_eval-04.js | running test ...
TEST-PASS | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_eval-04.js | test passed (time: 100.000ms)
TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_eval-05.js | running test ...
TEST-PASS | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_eval-05.js | test passed (time: 99.000ms)
TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\toolkit\devtools\debugger\tests\unit\test_breakpoint-01.js | running test ...
command timed out: 1200 seconds without output, attempting to kill
SIGKILL failed to kill process
using fake rc=-1
program finished with exit code -1
remoteFailed: [Failure instance: Traceback from remote host -- Traceback (most recent call last):
Failure: exceptions.RuntimeError: SIGKILL failed to kill process
]
Updated•13 years ago
|
Component: Developer Tools → Developer Tools: Debugger
QA Contact: developer.tools → developer.tools.debugger
Assignee | ||
Updated•13 years ago
|
Assignee: nobody → past
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•13 years ago
|
||
This issue affects Windows XP as well.
Assignee | ||
Comment 2•13 years ago
|
||
The cause of the failure is that the script URL reported by SpiderMonkey is this:
DBG-SERVER: Got a new script:[object Script], url: c:/Users/past/src/remote-debug/obj-i686-pc-mingw32/_tests/xpcshell/toolkit/devtools/debugger/tests/unit/test_breakpoint-01.js, startLine: 56, lineCount: 4, strictMode: undefined, function: undefined
While the path found by the test is this:
DBG-SERVER: Got: {
"to": "conn0.context2",
"type": "setBreakpoint",
"location": {
"url": "c:\\Users\\past\\src\\remote-debug\\obj-i686-pc-mingw32\\_tests\\xpcshell\\toolkit\\devtools\\debugger\\tests\\unit\\test_breakpoint-01.js",
"line": 59
}
}
Assignee | ||
Comment 3•13 years ago
|
||
The problem stems from the fact that the paths returned by SpiderMonkey in newScript notifications are the same on all platforms, while the do_get_file helper function returns a native path. I used a pattern I've seen in other tests to differentiate between Windows and UNIX.
Rob, this is an addendum to the big review in bug 697762. You may want to review this after you get through the other parts or I could attach this patch to the other bug for your review, after Dave approves it.
Tested on OS X and Windows 7. Try run at: https://tbpl.mozilla.org/?tree=Try&rev=e2030d391d13
Attachment #576776 -
Flags: review?(rcampbell)
Attachment #576776 -
Flags: review?(dcamp)
Comment 4•13 years ago
|
||
it's fine here, thanks. :)
Assignee | ||
Comment 5•13 years ago
|
||
(In reply to Panos Astithas [:past] from comment #3)
> Tested on OS X and Windows 7. Try run at:
> https://tbpl.mozilla.org/?tree=Try&rev=e2030d391d13
16 hours later and it still hasn't started, so I fired off a new one:
https://tbpl.mozilla.org/?tree=Try&rev=18e59bc9b255
Updated•13 years ago
|
Attachment #576776 -
Flags: review?(dcamp) → review+
Comment 6•13 years ago
|
||
Comment on attachment 576776 [details] [diff] [review]
Working patch
sorry for the delay on this. Patch looks fine to me.
Attachment #576776 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•