Mihai, * I deleted the "+" and "*" from jar.mn files because I think they are unneeded, what do you think? * I deleted aero specific stuff because I don't think they are needed too. (aero herits from winstrip right?) * What about files name?

Paul, I need tests on OSX/Windows, can you please run a try build with the patch?

Paul, try: -b do -e -p linux,macosx64,win32 -u mochitests -t none

Comment on attachment 575749 [details] [diff] [review] WIP patch v0.1 Review of attachment 575749 [details] [diff] [review]: ----------------------------------------------------------------- Patch looks good! As discussed on IRC, this patch needs an update for the winaero theme. The jar.mn file has two sections, one for aero. Please check and update the file as needed. Thank you!

paul, could you run a try build with the new patch? try: -b do -p all -u mochitests -t none

Sorry I meant try: -b do -p linux,macosx64,win32 -u mochitests -t none

Comment on attachment 575976 [details] [diff] [review] patch v0.2 >--- a/browser/themes/winstripe/jar.mn >+++ b/browser/themes/winstripe/jar.mn > skin/classic/aero/browser/tabview/tabview.png (tabview/tabview.png) > skin/classic/aero/browser/tabview/tabview-inverted.png (tabview/tabview-inverted.png) > skin/classic/aero/browser/tabview/tabview.css (tabview/tabview.css) > skin/classic/aero/browser/devtools/arrows.png (devtools/arrows.png) > skin/classic/aero/browser/devtools/goto-mdn.png (devtools/goto-mdn.png) > skin/classic/aero/browser/devtools/csshtmltree.css (devtools/csshtmltree.css) > skin/classic/aero/browser/devtools/gcli.css (devtools/gcli.css) > skin/classic/aero/browser/devtools/toolbarbutton-close.png (devtools/toolbarbutton-close.png) >+ skin/classic/browser/devtools/webconsole.css (devtools/webconsole.css) >+ skin/classic/browser/devtools/webconsole_networkpanel.css (devtools/webconsole_networkpanel.css) >+ skin/classic/browser/devtools/webconsole.png (devtools/webconsole.png) This needs to be skin/classic/aero/browser/

Dao, of course, sorry.

Comment on attachment 576690 [details] [diff] [review] patch v1.1 long overdue. thanks :)

Comment on attachment 576690 [details] [diff] [review] patch v1.1 Review of attachment 576690 [details] [diff] [review]: ----------------------------------------------------------------- Patch looks good. Sonny, thank you very much for your contribution! (apologies for the delay! the email with the review request got lost somehow...)

Comment on attachment 576690 [details] [diff] [review] patch v1.1 readded the preprocessing directive to pinstripe's jar.mn file. Styles weren't applying there.