Ulf Zibis Reporter
	Description • 13 years ago

User Agent: Mozilla/5.0 (Windows NT 5.1; rv:8.0) Gecko/20100101 Firefox/8.0
Build ID: 20111104165243

Steps to reproduce:

- have more than 1 accounts (here 8)
- select email in inbox of account A.
- hit reply




Actual results:

--> in From field of message composer there is identity of other account, but not A.

The failure occurs in 98 % of the emails, where the "Reply All" button is visible.
It too occurs in very rare cases, where "Reply All" button is not visible.
On different emails, different wrong accounts are choosen, but always the same on reply to the same email, even after restart, deleting panacea.dat + places.sqlite.

Aside, in ~20 % the "Reply All" button is visible, even if there is no other address than From and To.

Additionally I checked this behaviour on TB 7.0.1 installation on other Windows machine, from where I copied the profile to current TB 8.0 on this machine. On the other machine under TB 7.0.1, the failure was difficult to find, as it occurred very very rare, but reproducible on the same message. Too the unsuitable "Reply All" button" occurs more rare on TB 7.0.1.

As there is the possibility, that receivers get secret email addresses, IMO this bug is security relevant.


Expected results:

Identity of the message, from which the reply is inherited, should be pre-selected in fresh opened message composer.

	Hashem Masoud
	Comment 1 • 13 years ago

(In reply to Ulf.Zibis from comment #0)
Possible similar bugs: bug 303619, bug 684259, bug 696652.

	Ulf Zibis Reporter
	Comment 2 • 13 years ago

Yes, same problem, at least in the last two referred bugs.

	Thomas D. (:thomas8)
	Comment 3 • 13 years ago

(In reply to Ulf.Zibis from comment #2)
> Yes, same problem, at least in the last two referred bugs.

Not exactly: Bug 696652 is different from this bug reported by Ulf. Bug 696652 reports that we pick the wrong alias identity from multiple identities *within one account*. This bug 704613 claims that we even pick wrong (main/default) identies *across different accounts*. From comment 0, I assume that reporter (Ulf) is using several accounts with only one main/default identity per account, whereas Bug 696652 has multiple identities for one specific account.

Ulf, please note the difference between account and identity, it's not the same thing. Each account has one default identity and in addition, a single account may have one or more associated alias identities (as created in "Manage identities" dialogue).

	Thomas D. (:thomas8)
	Comment 4 • 13 years ago

Could this problem here be related to manual copying of mail messages from profile?

Ulf, did you copy the complete profile folder (e.g. \a1s2d3f.default\) or did you copy the \mail subfolder of that profile only (e.g. \a1s2d3f.default\mail\)?

If user creates one or more new accounts on new installation first, then these will get numbered, then copying of old mail only (where for each mail, old account numbers in different order are saved in mail source) could cause the problem of this bug, I believe.

	Ulf Zibis Reporter
	Comment 5 • 13 years ago

(In reply to Thomas D. from comment #3)
> Ulf, please note the difference between account and identity, it's not the
> same thing.
Thanks Thomas, I know. In my case there are 8 accounts, one has 2 identities.

(In reply to Thomas D. from comment #4)
> Could this problem here be related to manual copying of mail messages from
> profile?
Good catch !

> Ulf, did you copy the complete profile folder (e.g. \a1s2d3f.default\) or
> did you copy the \mail subfolder of that profile only (e.g.
> \a1s2d3f.default\mail\)?
I did both in the past for several reasons ... and even more. It happened that I manually renumbered the accounts, ids and servers in prefs.js in lack of a UI-based reordering facility. How could one do this otherwise?
Another reason was the change of my email provider. Then I had to rescue the content of my IMAP accounts or didn't want to download the whole content of a POP3 account again to prevent from duplicates in Inbox and local folders effected from filtering.

So now I believe that this was the cause for bug 667288, bug 667294, bug 668482.

> If user creates one or more new accounts on new installation first, then
> these will get numbered, then copying of old mail only (where for each mail,
> old account numbers in different order are saved in mail source) could cause
> the problem of this bug, I believe.
I sometimes did this, e.g. if I had the impression, that my profile contained too much garbage e.g. from old or incompatible add-ons.
Now while inspecting my Inbox file I can find different numbered account tags. Emails from before 2005 even lack the account tag at all.
Because I additionally have plenty of local folders, filled manually of by filters from different accounts, it seems to be _some work_ to "repair" my MBox files. Can you give some advice, how to do this without falling into new traps?

	Ulf Zibis Reporter
	Comment 6 • 13 years ago

To prevent from this wrong identities in case of Reply, could there be a warning, providing a selection dialogue to choose the correct sender identity when account id doesn't match the To: tag in concerning email?

	Ludovic Hirlimann [:Usul]
	Comment 7 • 13 years ago

check out the extension Identity chooser which helps prevent that kind of problems.

	Ulf Zibis Reporter
	Comment 8 • 13 years ago

(In reply to Ludovic Hirlimann [:Usul] from comment #7)
> check out the extension Identity chooser which helps prevent that kind of
> problems.
In some cases it helps, but mostly it's annoying, as it doesn't check for correct (To: <--> X-Account-Key:) pairing.
Additionally in the end it's too much error prone in daily routine on .. if user always selects the right identity.
It prevents the "Reply to list" button to work correctly. It opens a drop-down menu to select between "Reply to list", "Reply All", "Reply", but choosing the first only closes the drop-down menu doing nothing.

Anyway thanks for your hint.

It turns out, that I have to rename my Mbox files manually, to get rid from those problems.
I recently discovered column 'Account' in TB's list pane, which would hopefully help.

	Ulf Zibis Reporter
	Comment 9 • 13 years ago

As IMAP mbox doesn't contain X-Account-Key tag ...
What about, if messages are moved/copied from IMAP account to local or other account, were they added by correct X-Account-Key tag?

	Ulf Zibis Reporter
	Comment 10 • 13 years ago

(In reply to Ulf.Zibis from comment #8)
> I recently discovered column 'Account' in TB's list pane, which would
> hopefully help.

Does not help as hoped, see: Bug 707165

	WADA:World Anti-bad-Duping Agency
	Comment 11 • 13 years ago

(In reply to Ulf Zibis from comment #10)
> Does not help as hoped, (snip)

Account column is helpful in prediction of preset From: upon reply by Tb,
  by secretly seeing account column, with hiding the column from audience, 
  after checking main identity of account which was shown in account column,
  (if account without associated identity like Local Folders, you need to replace 
  by default account before your prediction)
  say "From: upon reply will be abc@x.y.z ...".
or in understanding of phenomenon.
  If preset From: is main identity of account which is shown in account column,
  (if account without associated identity like Local Folders, default account)
  it's probably by "X-Account-Key: based identity selection".
  If not, it's perhaps by "reply-to-self".

	Magnus Melin [:mkmelin]
	Comment 12 • 13 years ago

(In reply to Ulf Zibis from comment #5)
> I did both in the past for several reasons ... and even more. It happened
> that I manually renumbered the accounts, ids and servers in prefs.js in lack
> of a UI-based reordering facility. How could one do this otherwise?

Likely something got messed up there. If you can't reproduce with an account where no manual editing took place i doubt there's much we can do for your case.

	Ulf Zibis Reporter
	Comment 13 • 11 years ago

Suggested solution: In such and similar cases TB should warn the user, e.g. insert a red blinking message label above the From: field.
My suggestion for the priority to choose the From: identity on Reply (All):
 mail in "Local Folders" or global inbox ?
 + To: identity matches any alias of X-Account-Keys account ?
   + choose To: identity
   - To: tag exists ?
     + To: identity is valid for any account ?
       + choose To: identity
       - From: tag exists and is valid for any account ?
         + warn: "Check sender identity .." and preset From: identity
         - warn: "Check sender identity .." and preset X-Account-Keys default
       - warn: "Check sender identity .." and preset X-Account-Keys default
     - warn: "choose sender identity:" and preset X-Account-Keys default
 - X-Account-Key matches enclosing folders account ?
   + To: identity matches any alias of enclosing folders account ?
     + choose To: identity
     - warn: ".. originally sent to a@b.c" + preset accounts default identity
   - To: identity matches any alias of enclosing folders account ?
     + choose To: identity
     - To: identity matches any alias of X-Account-Keys account ?
       + warn: " .. " and preset enclosing folders default identity
       - warn: "choose sender identity: .. " and preset encl. folders default

	Wayne Mery (:wsmwk)
	Comment 14 • 11 years ago

privacy <> critical

	Christian Deligant
	Comment 15 • 10 years ago

Sorry to bump this up.
I noticed that if a message sent to one account (abc@domain.ix) is moved into a subfolder of another account (def@otherdomain.ix), hitting reply button puts as the sender the account owning the folder (def@) and not the account where the mail was send to in the first place (abc).

	David
	Comment 16 • 10 years ago

That is the correct action. It should also use the formatting (html or not) from the account the folder is in.

	Christian Deligant
	Comment 17 • 10 years ago

Well... I think that if a mail is sent to abd@, the sender of the reply should be abd@ and not someone else unless I expressly change the sender!
Example: I have a private address and an info@domain address. In the info@domain address there are several subfolders, related to projects.
I make a filter that some persons writing on the private address go in one of the subfolders.
I want to answer to those people with the original private address... so why is TB switching the user of the replies without telling me?
If this is the intended way, why has it changed ony recently (before it was working the other way round).
Or better said, what would be "the correct" way to group into one folder and subfolders emails coming on different accounts, but still keeping the original "To" as the "From" in the replys?

	David
	Comment 18 • 10 years ago

Set up another account for info@domain

	David Given
	Comment 19 • 10 years ago

This is happening to me: I have to identities, dg@cowlark.com and david.given@gmail.com. The cowlark address forwards to the gmail address, and I view email via an IMAP account on gmail.

Whenever I reply-all to a message, *even though* the message has been sent to dg@cowlark.com and is clearly labelled as such, and *even though* the account's default identity is dg@cowlark.com, the david.given@gmail.com identity is chosen. It's clearly a bug. (And a really annoying one, too; I frequently end up replying to mailing lists via the wrong address and my messages bounce.)

	John
	Comment 20 • 10 years ago

Same is happening to me.  I have 4 identities and when I reply, TB selects a different identity to send the response from and not the one I was working in and which received the incoming message.  It also happens when I reply to all and forward.  This has to be a bug, no logical reason for it to work this way.

	TerryR
	Comment 21 • 9 years ago

This is a very annoying bug - happens on most but not all replies. Especially happens on replies to emails that have been sent to a folder other than Inbox by filters, but sometimes happens on messages in Inbox too.

	Michael Bauer
	Comment 22 • 8 years ago

Recently had to do a rescue for someone in the office from Outlook Express on XP, moving to Tb first and the the entire Tb profile to a new Windows 10 system. Everything is working as expected except that the user has several (from what I can tell) correctly set up accounts i.e. incoming mail is received and filtered correctly and each email account specifies the right Outgoing server under Manage Identities. But in a seemingly random fashion, when the user hits the Reply button, Tb chooses an outgoing identity at random.
Given the age of this bug, could we not introduce a patch solution i.e. could Tb not automatically check, once it has created the Reply (rightly or wrongly) whether the identities match and if not to force them to use the same identity, which is the default user case?

	Mark
	Comment 23 • 8 years ago

This bug also applies on the Mac OS/X platform.
Build 45.1.1 on el cap 10.11.5

Happens with reply and reply all.

very irritating.

	Wayne Mery (:wsmwk)
	Comment 25 • 7 years ago

bug 888957 and bug 1052075 are duplicates?

	:aceman
	Comment 26 • 6 years ago

In bug 394216, we have made changes in identity (From) matching compositions from messages that have problematic X-Identity-Key or X-Account-Key, have been moved between accounts or are shared in the same folder on IMAP across multiple TB installations.
The change is in TB60 so I'd suggest all the similar bugs get re-tested by the reporters in that version.