Closed
Bug 704692
Opened 13 years ago
Closed 13 years ago
[traceback] App upload fails with "File is not a zip file " at /developers/app/submit/2
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
VERIFIED
FIXED
6.3.3
People
(Reporter: krupa.mozbugs, Assigned: kumar)
References
()
Details
(Keywords: regression)
steps to reproduce:
expected behavior:
actual behavior:
File "/data/www/apps-preview-dev.allizom.org/zamboni/vendor/src/django/django/core/handlers/base.py", line 111, in get_response
response = callback(request, *callback_args, **callback_kwargs)
File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/decorators.py", line 102, in wrapper
return f(*args, **kw)
File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/decorators.py", line 94, in wrapper
return f(*args, **kw)
File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/decorators.py", line 60, in wrapper
return f(request, *args, webapp=show_webapp, **kwargs)
File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/amo/decorators.py", line 28, in wrapper
return func(request, *args, **kw)
File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/views.py", line 1327, in wrapper
return f(request, *args, **kw)
File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/devhub/views.py", line 1454, in submit_addon
addon = Addon.from_upload(data['upload'], p)
File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/addons/models.py", line 377, in from_upload
Version.from_upload(upload, addon, platforms)
File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/versions/models.py", line 90, in from_upload
File.from_upload(upload, v, platform, parse_data=data)
File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/files/models.py", line 146, in from_upload
data = cls.get_jetpack_metadata(upload.path)
File "/data/www/apps-preview-dev.allizom.org/zamboni/apps/files/models.py", line 186, in get_jetpack_metadata
zip_ = zipfile.ZipFile(path)
File "/usr/lib64/python2.6/zipfile.py", line 696, in __init__
self._GetContents()
File "/usr/lib64/python2.6/zipfile.py", line 716, in _GetContents
self._RealGetContents()
File "/usr/lib64/python2.6/zipfile.py", line 728, in _RealGetContents
raise BadZipfile, "File is not a zip file"
File is not a zip file
Reporter | ||
Comment 1•13 years ago
|
||
Updated•13 years ago
|
Assignee: nobody → kumar.mcmillan
Target Milestone: --- → 6.3.3
Assignee | ||
Comment 2•13 years ago
|
||
My bad, fixed: https://github.com/mozilla/zamboni/commit/ee8d39f
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 3•13 years ago
|
||
btw, we had a failing test for this :) but CI was not reporting to IRC so I missed it.
Reporter | ||
Comment 4•13 years ago
|
||
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•