Closed Bug 705910 Opened 13 years ago Closed 13 years ago

Review of sync client code

Categories

(Web Apps Graveyard :: AppsInTheCloud, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: ianbicking, Assigned: rnewman)

Details

(Whiteboard: client devPreviewNonBlocker)

I'd like a review of the sync client code. It has already been merged into the tree to facilitate integration with different components of OWA, so the review is somewhat retroactive. The pull request (now closed) is https://github.com/mozilla/openwebapps/pull/133 - there has been a review just of the pieces that integrate into the extension. As a result there has been some development since this pull request, including the addition of what I hope are helpful comments in sync.js. Most of the sync client is in sync.js: https://github.com/mozilla/openwebapps/blob/develop/addons/jetpack/lib/sync.js Along with a few tests here: https://github.com/mozilla/openwebapps/tree/develop/sync/tests And integration with the HTML version of the repository is in sync* here: https://github.com/mozilla/openwebapps/tree/develop/site/jsapi (these are less critical) The sync code itself is used both in content Javascript and the extension.
OS: Linux → All
Hardware: x86 → All
Whiteboard: client
Whiteboard: client → client devPreviewNonBlocker
A Pivotal Tracker story has been created for this Bug: https://www.pivotaltracker.com/story/show/24808909
Jason: I get this when I click that link. {"message":"You have been signed out.","status":"SIGNOUT"}
Right. Disregard the Pivotal tracker comment. I was testing Bugzilla integration into pivotal tracker and accidentally caused comments to be auto-generated onto some of the bugs.
The old app sync codebase is no longer going to be supported. Apps in the cloud will be under a different codebase. None of these bugs are valid anymore.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
Product: Web Apps → Web Apps Graveyard
You need to log in before you can comment on or make changes to this bug.