Closed
Bug 705998
Opened 13 years ago
Closed 13 years ago
IonMonkey: ion/bug674694.js hangs with greedy allocator
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: jandem, Assigned: jandem)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
dvander
:
review+
|
Details | Diff | Splinter Review |
Seems to be a regression from my block reordering patch (bug 699415). I'll investigate.
|
Assignee | |
Comment 1•13 years ago
|
||
Reduced:
function f0(p0) {
do {
} while (p0);
while (p0) {
do {
} while (p0);
}
}
f0(0);
|
|
Assignee | |
Comment 2•13 years ago
|
||
The block ordering change broke FindNaturalLoops, it has to see inner backedges before outer backedges.
Attachment #577523 -
Flags: review?(sstangl)
|
||
Updated•13 years ago
|
Attachment #577523 -
Flags: review?(sstangl) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Thanks for the quick review.
http://hg.mozilla.org/projects/ionmonkey/rev/10b888d2474a
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Comment 4•13 years ago
|
||
The issue is not entirely fixed: the assert introduced by the above patch trips basic/innerLoopIntOuterDouble.js with --ion --ion-regalloc=greedy.
Unfortunately, the assert must know about the osrBlock's ID.
Attachment #577807 -
Flags: review?(dvander)
|
|
||
Updated•13 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Updated•13 years ago
|
Attachment #577807 -
Flags: review?(dvander) → review+
|
|
||
Comment 5•13 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•