Closed
Bug 706192
Opened 13 years ago
Closed 13 years ago
ua.css specifies invalid value 'none' for 'clip' property
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Just noticed this in my error console:
=====
Warning: Error in parsing value for 'clip'. Declaration dropped.
Source File: resource://gre-resources/ua.css
Line: 273
=====
This is from this line:
>276 clip:none !important;
http://mxr.mozilla.org/mozilla-central/source/layout/style/ua.css#276
which was added in bug 685779.
There is no 'none' value for clip -- the equivalent value (for no clipping) is 'auto':
http://www.w3.org/TR/CSS21/visufx.html#propdef-clip
Assignee | ||
Comment 1•13 years ago
|
||
bug 685779 landed before the last migration (and is in aurora for Firefox 10), so we probably want to fix this on aurora after it's fixed on trunk.
tracking-firefox10:
--- → ?
Assignee | ||
Comment 2•13 years ago
|
||
Comment 3•13 years ago
|
||
I included this fix in my patch for bug 702146, I'm just waiting for review on it. I'm not sure if we need to take this fix on Aurora/Firefox 10 or not... I've previously discussed it with Roc, and we thought we'd let the patch in bug 702146 (along with this fix) ship in Firefox 11. You're welcome to try to convince me otherwise! :)
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Chris Pearce (:cpearce) (Mozilla Corporation) from comment #3)
> I've previously discussed it with Roc, and we thought we'd let the
> patch in bug 702146 (along with this fix) ship in Firefox 11. You're welcome
> to try to convince me otherwise! :)
Ah -- I was assuming there might be security and/or rendering-potentially-busted implications, but it sounds like it's not too bad.
Marking this as depends-on bug 702146 for now (to be updated to FIXED by that bug when it lands). Feel free to dupe if that's cleaner.
Depends on: 702146
Assignee | ||
Updated•13 years ago
|
Attachment #577687 -
Attachment description: fix → fix (included in patch on bug 702146)
Attachment #577687 -
Flags: review?(chris)
Assignee | ||
Updated•13 years ago
|
tracking-firefox10:
? → ---
Assignee | ||
Comment 5•13 years ago
|
||
Looks like bug 702146's patch has now landed, so this is FIXED by that bug.
Assignee: dholbert → nobody
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Updated•13 years ago
|
Assignee: nobody → dholbert
You need to log in
before you can comment on or make changes to this bug.
Description
•