Closed Bug 706777 Opened 13 years ago Closed 13 years ago

Automatically repopulate AddonRepository database on application upgrade

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla11
Tracking Status
firefox10 --- verified

People

(Reporter: Unfocused, Assigned: Unfocused)

References

Details

(Whiteboard: [qa!])

Attachments

(1 file, 1 obsolete file)

When the schema of AddonRepository's database has a significant change, there can be new rows or tables that make an important contribution to the functioning of the Addons Manager - such as compatibility overrides. Ideally, we want to populate that with fresh data as soon as possible.
Attached patch WiP v1 (obsolete) (deleted) — Splinter Review
Dave, do you see any downside to this approach?
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Attachment #578957 - Flags: feedback?(dtownsend)
Comment on attachment 578957 [details] [diff] [review] WiP v1 Trying the update.js/selectAddons.js route, as suggested on IRC.
Attachment #578957 - Attachment is obsolete: true
Attachment #578957 - Flags: feedback?(dtownsend)
Attached patch Patch v1 (deleted) — Splinter Review
Attachment #579041 - Flags: review?(dtownsend)
Comment on attachment 579041 [details] [diff] [review] Patch v1 Review of attachment 579041 [details] [diff] [review]: ----------------------------------------------------------------- ::: toolkit/mozapps/extensions/content/selectAddons.js @@ +128,1 @@ > Looks like you left two blank lines here
Attachment #579041 - Flags: review?(dtownsend) → review+
Fixed re-disabling the cache at the end of the test. https://hg.mozilla.org/integration/fx-team/rev/109bb6c0e72a
Flags: in-testsuite+
Flags: in-litmus-
Summary: Automatically repopulate AddonRepository database when doing significant schema upgrades → Automatically repopulate AddonRepository database on application upgrade
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla11
Comment on attachment 579041 [details] [diff] [review] Patch v1 Preemptively requesting approval (it's not merged into central yet). Important piece of the compatible-by-default story, required for enabling it on a release version.
Attachment #579041 - Flags: approval-mozilla-aurora?
This should land on M-C before Aurora approval is granted.
Comment on attachment 579041 [details] [diff] [review] Patch v1 [Triage Comment] Approving low-risk add-ons default to compatible bugs for Aurora with the understanding that we're going to come up with explicit methods of tracking any regressions in aurora/beta related to this and stay on top of them. Please land on aurora only when this has been landed on m-c.
Attachment #579041 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Note: The patch here is dependent on the patch in bug 693906. And that can't land on Aurora until bug 707328 can also land on Aurora. Dependency chains are fun.
Status: RESOLVED → UNCONFIRMED
Ever confirmed: false
Resolution: FIXED → ---
Status: UNCONFIRMED → RESOLVED
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Is this something QA can verify?
Whiteboard: [qa?]
Kinda... it's a little awkward to do so at the moment, because AMO only has one compatibility override (that I know of), and that's for Addon Compatibility Reporter v1.0 and below. But there's v1.0.1 and v1.0.2 out now, which don't have a compatibility override... so you have to make sure Firefox doesn't automatically upgrade to those versions. 1. Start Firefox 9 2. Disable addon update 3. Install ACR v1.0 4. Disable ACR (useful because that version disables compatible-by-default) 4. Upgrade to Firefox 10 or higher 5. ACR should be marked as incompatible Without the fix from this bug, ACR would only be made incompatible after the first background update check after the upgrading to Firefox 10 or newer.
Whiteboard: [qa?] → [qa+]
Mozilla/5.0 (X11; Linux x86_64; rv:10.0) Gecko/20100101 Firefox/10.0 Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:10.0) Gecko/20100101 Firefox/10.0 Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0) Gecko/20100101 Firefox/10.0 Mozilla/5.0 (X11; Linux x86_64; rv:11.0a2) Gecko/20120102 Firefox/11.0a2 Verified on Firefox 10 (Beta 2) and 11 (Aurora) on ubuntu 11.10, Mac OS 10.6 and Windows 7. Disabled ACR version 1.0 is listed as incompatible after the upgrade.
Status: RESOLVED → VERIFIED
Whiteboard: [qa+] → [qa!]
Depends on: 718536
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: