Closed
Bug 706886
Opened 13 years ago
Closed 12 years ago
Line-through disappears after editing overridden rule in style inspector
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 22
People
(Reporter: harth, Assigned: miker)
Details
(Whiteboard: [ruleview])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
harth
:
review+
|
Details | Diff | Splinter Review |
If you edit an overridden rule in the ruleview the line-through / strikeout indicator disappears. The line-through should be re-applied after editing the rule.
Updated•13 years ago
|
Assignee: nobody → dcamp
Comment 2•13 years ago
|
||
Fairly straightforward: * During refresh, TextPropertyEditor hides the strikethrough while editing (to avoid looking strange) by checking if there's an active editor on its spans. * inplace editor was calling done() callback before tearing itself down. * done() indirectly causes a refresh (good) which saw a still-active editor (bad). Attached patch tears down the editor before calling the done() callback.
Attachment #579906 -
Flags: review?(jwalker)
Attachment #579906 -
Flags: feedback?(rcampbell)
Comment 3•13 years ago
|
||
Comment on attachment 579906 [details] [diff] [review] fix Review of attachment 579906 [details] [diff] [review]: ----------------------------------------------------------------- ::: browser/devtools/styleinspector/CssRuleView.jsm @@ +1284,1 @@ > } This is a blatant 'to prove i read it' comment: this._clear(); if (typeof this.done == "function") { let value = this.cancelled ? this.initial : this.input.value.trim(); this.done(value, !this.cancelled); } It's 0.0002ms faster in the case when this.done isn't set, and it doesn't crash if this.done is set incorrectly, and it read easier to me, and I really don't care if you ignore me.
Attachment #579906 -
Flags: review?(jwalker) → review+
Updated•13 years ago
|
Whiteboard: [ruleview] → [ruleview][land-in-fx-team]
Comment 5•13 years ago
|
||
Comment on attachment 579906 [details] [diff] [review] fix yeah, sure thing.
Attachment #579906 -
Flags: feedback?(rcampbell) → feedback+
Comment 6•13 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b8281fe1b926
Status: NEW → ASSIGNED
Whiteboard: [ruleview][land-in-fx-team] → [ruleview][fixed-in-fx-team]
Updated•13 years ago
|
Whiteboard: [ruleview][fixed-in-fx-team] → [ruleview]
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b8281fe1b926
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 8•12 years ago
|
||
Unfortunately, this is happening again.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment 9•12 years ago
|
||
Not sure when I can get to this, so assigning to default in case someone else wants to pick it up.
Assignee: dcamp → nobody
Updated•12 years ago
|
Blocks: DevToolsPaperCuts
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → mratcliffe
Assignee | ||
Comment 10•12 years ago
|
||
Simple fix. Use linethrough if we should when the value is overridden. We were displaying as overridden when the name was changed, but not the value.
Attachment #579906 -
Attachment is obsolete: true
Attachment #716483 -
Flags: review?(fayearthur)
Assignee | ||
Updated•12 years ago
|
Whiteboard: [ruleview] → [ruleview][has-patch]
Reporter | ||
Updated•12 years ago
|
Attachment #716483 -
Flags: review?(fayearthur) → review+
Assignee | ||
Updated•12 years ago
|
Whiteboard: [ruleview][has-patch] → [ruleview][land-in-fx-team]
Assignee | ||
Comment 11•12 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a5c189768303
Whiteboard: [ruleview][land-in-fx-team] → [ruleview][fixed-in-fx-team]
Comment 12•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a5c189768303
Status: REOPENED → RESOLVED
Closed: 13 years ago → 12 years ago
Resolution: --- → FIXED
Whiteboard: [ruleview][fixed-in-fx-team] → [ruleview]
Target Milestone: --- → Firefox 22
Updated•11 years ago
|
No longer blocks: DevToolsPaperCuts
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•