I presume this is how it'll come up, but lacking Windows 8 I can't test.

Er, pretend that I added a comma after Windows 7 too.

Comment on attachment 652858 [details] [diff] [review] add Windows 8 to the platform list Review of attachment 652858 [details] [diff] [review]: ----------------------------------------------------------------- r=me with , added :D Not sure if you care or not, but you have kWindowsServer2003 listed already. Server 2012 has the same value of 0x60002

This should support Windows 8 (and, incidentally, Mac OS X 10.8). Coming next: some tests. Benoit, do you remember how we broke the blacklist accidentally in previous Firefox versions? I remember it being about us changing an enumerated value and some comparison being wrong. I just don't want to repeat that!

The bug I was referring to is bug 711656.

Forgot the widgets/cocoa part of the patch.

Try: https://tbpl.mozilla.org/?tree=Try&rev=0544152632ca

These patches don't compile for me on Windows 8, due to a missing comma in the gfxWindowsPlatform.h enum.

You have to pretend it's there, see Comment 2 :D

https://hg.mozilla.org/integration/mozilla-inbound/rev/02a60618e928 https://hg.mozilla.org/integration/mozilla-inbound/rev/3f74f34beaa4 https://hg.mozilla.org/integration/mozilla-inbound/rev/e938ef11c6d2

https://hg.mozilla.org/mozilla-central/rev/02a60618e928 https://hg.mozilla.org/mozilla-central/rev/3f74f34beaa4 https://hg.mozilla.org/mozilla-central/rev/e938ef11c6d2

Comment on attachment 652858 [details] [diff] [review] add Windows 8 to the platform list [Approval Request Comment] Bug caused by (feature/regressing bug #): none User impact if declined: Inability for us to block hardware acceleration on Windows 8 at all Testing completed (on m-c, etc.): On m-c for a while Risk to taking this patch (and alternatives if risky): Could break all blacklisting, though it *shouldn't* since we have a lot of tests String or UUID changes made by this patch: none

Comment on attachment 652914 [details] [diff] [review] support windows 8 and os x 10.8 from gfxInfo [Approval Request Comment] Bug caused by (feature/regressing bug #): User impact if declined: Testing completed (on m-c, etc.): Risk to taking this patch (and alternatives if risky): String or UUID changes made by this patch:

remote: https://hg.mozilla.org/releases/mozilla-beta/rev/2e588425bf78 remote: https://hg.mozilla.org/releases/mozilla-beta/rev/a6cf6997536f remote: https://hg.mozilla.org/releases/mozilla-beta/rev/5020f7413641 remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/6a320ddf2dfe remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/1b6102284032 remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/22e3efa1a108