Closed
Bug 707021
Opened 13 years ago
Closed 10 years ago
Support MSVC 2011 compiler in comm-central. (Port bug 687225)
Categories
(MailNews Core :: Build Config, defect)
Tracking
(Not tracked)
RESOLVED
INCOMPLETE
Thunderbird 11.0
People
(Reporter: sgautherie, Assigned: sgautherie)
References
(Depends on 1 open bug)
Details
Attachments
(1 file)
(deleted),
patch
|
standard8
:
review+
standard8
:
approval-comm-aurora-
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•13 years ago
|
||
http://hg.mozilla.org/comm-central/rev/ae36b4029256
(Av1-SM) Package MSVC 2011 dlls. rs=Callek.
Per bug 694371 comment 13.
Flags: in-testsuite-
Assignee | ||
Comment 2•13 years ago
|
||
http://mxr.mozilla.org/comm-central/search?string=MANIFESTUAC&case=1&find=%2Fconfigure.in%24
"Found 2 matching lines"
These were removed from m-c by (one of the changesets included in)
http://hg.mozilla.org/mozilla-central/rev/18f64f620273
"Merging with mozilla-central."
Alternatively, I could add it to MSVC 2011 too :-|
(Untested ftb.)
Attachment #578459 -
Flags: review?(mbanner)
Assignee | ||
Comment 3•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #2)
> These were removed from m-c by (one of the changesets included in)
> http://hg.mozilla.org/mozilla-central/rev/18f64f620273
> "Merging with mozilla-central."
That was bug 570365: let's port it!
Depends on: 570365
Updated•13 years ago
|
Attachment #578459 -
Flags: review?(mbanner) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 578459 [details] [diff] [review]
(Bv1) Remove obsolete "-MANIFESTUAC:NO" workaround, Add support for MSVC 2011 compiler
[Checked in: Comment 4]
http://hg.mozilla.org/comm-central/rev/62f30caedd94
Attachment #578459 -
Attachment description: (Bv1) Remove obsolete "-MANIFESTUAC:NO", Support MSVC 2011 compiler → (Bv1) Remove obsolete "-MANIFESTUAC:NO" workaround, Add support for MSVC 2011 compiler
[Checked in: Comment 4]
Assignee | ||
Comment 5•13 years ago
|
||
PS: I leave Thunderbird packaging part to be done by a TB contributor...
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 11.0
Assignee | ||
Comment 6•13 years ago
|
||
Comment on attachment 578459 [details] [diff] [review]
(Bv1) Remove obsolete "-MANIFESTUAC:NO" workaround, Add support for MSVC 2011 compiler
[Checked in: Comment 4]
"approval-comm-aurora=?":
*"-MANIFESTUAC:NO" fix, available since mozilla2.0b1.
*Do you want this part for comm-beta too?
*MSVC 2011 part, available in mozilla10.
Attachment #578459 -
Flags: approval-comm-aurora?
Comment 7•13 years ago
|
||
Comment on attachment 578459 [details] [diff] [review]
(Bv1) Remove obsolete "-MANIFESTUAC:NO" workaround, Add support for MSVC 2011 compiler
[Checked in: Comment 4]
I don't think we need to port this across - 2011 is quite new, and we've only just had a couple of issues raised by devs. Additionally, most devs will be working trunk only.
The manifest fix also doesn't affect us as we've worked around in different ways and we're currently on vc8.
Attachment #578459 -
Flags: approval-comm-aurora? → approval-comm-aurora-
Assignee | ||
Comment 8•13 years ago
|
||
V.Fixed in
/pub/thunderbird/tinderbox-builds/comm-central-tested-win32/1322856213
Status: RESOLVED → VERIFIED
Comment 9•13 years ago
|
||
Removing the obsolete "-MANIFESTUAC:NO" workaround actually broke the VC 9 builds - see bug 708799.
We need to work out what we're missing as we've obviously not got something right. I don't mind if we want to move this manifest section to a different bug.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Comment 10•10 years ago
|
||
MSVC 2011 ain't been supported for a long time.
Status: REOPENED → RESOLVED
Closed: 13 years ago → 10 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•