Closed
Bug 707121
Opened 13 years ago
Closed 13 years ago
msvc* dlls will never get removed on update
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla11
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
When we change the version of MSVC that we're using, we'll start shipping some new dlls, however we won't actually remove the old ones. This is because in removed-files.in they are listed as: @BINPATH@/msvcm80.dll @BINPATH@/msvcp80.dll (etc) However, the golden rule for moving/copying things from package-manifest.in is that you remove @BINPATH@. Currently we're trying to remove bin/msvc* rather than just msvc* (I verified this looking at the make partial mar step in a nightly builds).
Attachment #578538 -
Flags: review?(khuey)
Flags: in-testsuite-
Attachment #578538 -
Flags: review?(khuey) → review+
|
Assignee | |
Comment 1•13 years ago
|
||
Landed on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/0a8ff3d835ba
Whiteboard: [inbound]
Target Milestone: --- → Firefox 11
|
||
Comment 2•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/0a8ff3d835ba
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•13 years ago
|
Whiteboard: [inbound]
|
||
Updated•6 years ago
|
Component: Build Config → General
Product: Firefox → Firefox Build System
|
||
Updated•6 years ago
|
Target Milestone: Firefox 11 → mozilla11
You need to log in
before you can comment on or make changes to this bug.
Description
•