Closed
Bug 707577
Opened 13 years ago
Closed 13 years ago
Create a |fast-package| target on mobile
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla15
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(2 files)
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
This target will be used (maybe temporarily) to trigger speed optimizations when packaging.
Attachment #578946 -
Flags: review?(khuey)
Comment on attachment 578946 [details] [diff] [review]
Patch
Review of attachment 578946 [details] [diff] [review]:
-----------------------------------------------------------------
I don't think we should have a separate target. Either we're convinced enough of a change to do it for regular packaging or we shouldn't be imposing it on developers.
Attachment #578946 -
Flags: review?(khuey) → review-
Comment on attachment 578946 [details] [diff] [review]
Patch
Ok, after looking at the optimizations you have in mind I changed my mind.
Attachment #578946 -
Flags: review- → review+
|
||
Comment 3•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/5667275e8112
Should the same change be made to mobile/android/build.mk ?
|
||
Comment 4•13 years ago
|
||
Yeah, that seems more useful nowadays...
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
Assignee | |
Comment 6•13 years ago
|
||
(In reply to Nick Thomas [:nthomas] from comment #3)
> Should the same change be made to mobile/android/build.mk ?
Indeed.
|
|
||
Comment 8•13 years ago
|
||
Adds the same target for the native android app. Also fiddles the previously added target to pass the variable as a makefile var, not an environment var.
Attachment #620254 -
Flags: review?(khuey)
Attachment #620254 -
Flags: review?(khuey) → review+
|
|
||
Comment 9•13 years ago
|
||
|
|
||
Updated•13 years ago
|
Target Milestone: --- → mozilla15
|
||
Comment 10•13 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•