Closed
Bug 708116
Opened 13 years ago
Closed 13 years ago
Factor out video frame update logic
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(1 file, 3 obsolete files)
|
(deleted),
patch
|
cajbir
:
review+
|
Details | Diff | Splinter Review |
Currently nsMediaDecoder/nsBuiltinDecoder have logic for setting the current video frame and updating the current video frame intrinsic size, triggering reflows and invalidation.
This needs to be factored out so that it can be used when the media element doesn't have a decoder, e.g. when it's playing a MediaStream.
|
Assignee | |
Comment 1•13 years ago
|
||
This introduces a new nsVideoFrameContainer object to manage the "current video frame" state of a video element.
|
|
Assignee | |
Comment 2•13 years ago
|
||
Attachment #579483 -
Attachment is obsolete: true
Attachment #596894 -
Flags: review?(chris.double)
|
|
Assignee | |
Comment 3•13 years ago
|
||
rename to mozilla::VideoFrameContainer.
Attachment #596894 -
Attachment is obsolete: true
Attachment #596894 -
Flags: review?(chris.double)
Attachment #596895 -
Flags: review?(chris.double)
|
|
Assignee | |
Comment 4•13 years ago
|
||
Merged in some extra changes from my media-streams branch. Basically just need to keep a pointer to the element in the class.
Attachment #596895 -
Attachment is obsolete: true
Attachment #596895 -
Flags: review?(chris.double)
Attachment #596953 -
Flags: review?(chris.double)
|
||
Comment 5•13 years ago
|
||
Comment on attachment 596953 [details] [diff] [review]
fix v4
License headers for new files should probably use the new boilerplate?
http://www.mozilla.org/MPL/headers/
Attachment #596953 -
Flags: review?(chris.double) → review+
|
|
Assignee | |
Comment 6•13 years ago
|
||
|
||
Comment 7•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla13
You need to log in
before you can comment on or make changes to this bug.
Description
•