Closed
Bug 708322
Opened 13 years ago
Closed 13 years ago
NoteJSChild shouldn't add children if the non-CCKind node is non-gray
Categories
(Core :: XPConnect, defect)
Core
XPConnect
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: mccr8, Assigned: mccr8)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
(deleted),
patch
|
billm
:
review+
|
Details | Diff | Splinter Review |
Bill noticed that we only skip children when we're non-gray in the AddToCCKind case. NoteWeakMapChild always does this. Could be an improvement in some situations.
|
Assignee | |
Comment 1•13 years ago
|
||
Mark bits of static strings can be checked now without crashing, so this is pretty simple.
Assignee: nobody → continuation
|
|
Assignee | |
Comment 2•13 years ago
|
||
Comment on attachment 587069 [details] [diff] [review]
return immediately if JS thing is non-gray
https://hg.mozilla.org/try/rev/0415ae2b4b8d
Attachment #587069 -
Flags: review?(wmccloskey)
Attachment #587069 -
Flags: review?(wmccloskey) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Thanks for the quick review.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cef10089737
Target Milestone: --- → mozilla12
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•