Closed
Bug 708613
Opened 13 years ago
Closed 13 years ago
Move SplitView component in devtools/shared
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 12
People
(Reporter: cedricv, Assigned: cedricv)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
rcampbell
:
review+
|
Details | Diff | Splinter Review |
Currently in devtools/styleeditor but this is a generic UI module that we intend to reuse for Scratchpad (see bug 708213) and other tools.
Let's move in in shared/ then.
Assignee | ||
Comment 1•13 years ago
|
||
Updated•13 years ago
|
Attachment #580036 -
Flags: review?(rcampbell)
Comment 2•13 years ago
|
||
Comment on attachment 580036 [details] [diff] [review]
Move it.
+ content/browser/splitview.css (shared/splitview.css)
* content/browser/styleeditor.xul (styleeditor/styleeditor.xul)
- content/browser/splitview.css (styleeditor/splitview.css)
we should put this in content/browser/devtools/...
(and should probably move the scratchpad and associates there as well in a separate patch).
Attachment #580036 -
Flags: review?(rcampbell) → review+
Comment 3•13 years ago
|
||
Shouldn't we land this?
Assignee | ||
Comment 5•13 years ago
|
||
Attachment #580036 -
Attachment is obsolete: true
Comment 6•13 years ago
|
||
Status: NEW → ASSIGNED
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 7•13 years ago
|
||
Backed out in:
https://hg.mozilla.org/integration/fx-team/rev/a89c7779fed4
see log:
https://tbpl.mozilla.org/php/getParsedLog.php?id=8670802&tree=Fx-Team
Whiteboard: [fixed-in-fx-team] → [backed-out]
Assignee | ||
Comment 8•13 years ago
|
||
Attachment #589853 -
Attachment is obsolete: true
Attachment #590096 -
Flags: review?(rcampbell)
Updated•13 years ago
|
Attachment #590096 -
Flags: review?(rcampbell) → review+
Updated•13 years ago
|
Whiteboard: [backed-out] → [land-in-fx-team]
Comment 9•13 years ago
|
||
Whiteboard: [land-in-fx-team] → [fixed-in-fx-team]
Comment 10•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment 11•13 years ago
|
||
Comment on attachment 590096 [details] [diff] [review]
Add missing module install in shared/Makefile...
[Approval Request Comment]
Regression caused by (bug #): New feature.
User impact if declined: Addon Compatibility will be affected*
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): It appears large, but it's really just a file move.
* About Addon Compatibility.
Fx11 is the first version of Firefox with this new feature. The SplitView.jsm file is already being used by an addon we are about to include in the browser. Not having this in its ultimate destination makes using this shared component more difficult. We only realized the potential of having this as a shared library later in the development of Firefox 12, hence our late request.
There really is negligible impact to landing this in aurora. Really.
Attachment #590096 -
Flags: approval-mozilla-aurora?
Updated•13 years ago
|
Attachment #590096 -
Flags: approval-mozilla-aurora?
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•