Jason Duell Reporter
	Description • 13 years ago

Taras: like it says.  

By the way, what's the reason for putting a max val in the historgrams.h file?  Seems like we could just capture whatever value it is and then the reporting UI could find the min/max/etc and create the right buckets.

	(dormant account)
	Comment 1 • 13 years ago

(In reply to Jason Duell (:jduell) from comment #0)
> Created attachment 580542 [details] [diff] [review]
> Change all disk cache delete/open timings to 10 minutes (from 10 seconds).
> 
> Taras: like it says.  
> 
> By the way, what's the reason for putting a max val in the historgrams.h
> file?  Seems like we could just capture whatever value it is and then the
> reporting UI could find the min/max/etc and create the right buckets.

For one-off entries we have the .sum field which reports the exact value. Reason for not keeping track of exact values is that it minimizes memory allocation during telemetry probe recording.

	(dormant account)
	Comment 2 • 13 years ago

Comment on attachment 580542 [details] [diff] [review]
Change all disk cache delete/open timings to 10 minutes (from 10 seconds).

Jason, I didnt get a response to my question above, I don't think changing telemetry values will be of sufficient value for this. Ie if these values are only recorded once, .sum already has the number you are looking for. It's a matter of asking someone in #metrics to give you a distribution of .sum values.