Closed
Bug 710292
Opened 13 years ago
Closed 13 years ago
create a typedef for nsCharSeparatedTokenizer<nsContentUtils::IsHTMLWhitespace> and convert users in the tree to use the new typedef
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: imelven, Assigned: santiago.gimeno)
References
Details
(Whiteboard: [mentor=khuey][lang=c++])
Attachments
(1 file)
|
(deleted),
patch
|
khuey
:
review+
|
Details | Diff | Splinter Review |
as part of feedback on bug 341604 khuey suggested creating a "typedef nsCharSeparatedTokenizer<nsContentUtils::IsHTMLWhitespace> HTMLSplitOnSpacesTokenizer (or something)" in nsContentUtils.h and changing the existing users in the tree to use this new typedef this seems like a pretty great first bug also.
|
Reporter | |
Updated•13 years ago
|
Blocks: framesandbox
|
|
Reporter | |
Comment 1•13 years ago
|
||
nsCharSeparatedTokenizerTemplate<nsContentUtils::IsHTMLWhitespace> looks to be the actual thing to typedef
|
||
Comment 2•13 years ago
|
||
Kyle, feel free to take your name off this if you want.
Whiteboard: [mentor=khuey][lang=c++]
|
Assignee | |
Comment 3•13 years ago
|
||
Attachment #585716 -
Flags: review?(khuey)
|
|
||
Updated•13 years ago
|
Assignee: nobody → santiago.gimeno
Comment on attachment 585716 [details] [diff] [review] Add and use new HTMLSplitOnSpacesTokenizer typedef Review of attachment 585716 [details] [diff] [review]: ----------------------------------------------------------------- Nice patch. Thanks!
Attachment #585716 -
Flags: review?(khuey) → review+
|
||
Comment 6•13 years ago
|
||
Thanks! :-) https://hg.mozilla.org/mozilla-central/rev/80cc942b8db7
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
You need to log in
before you can comment on or make changes to this bug.
Description
•