See bug 598482 comment 79.

Comment on attachment 606923 [details] [diff] [review] Widget Wil/Did Paint Review of attachment 606923 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/qt/nsWindow.cpp @@ +1061,5 @@ > + { > + nsEventStatus status; > + nsPaintEvent willPaintEvent(true, NS_WILL_PAINT, this); > + willPaintEvent.willSendDidPaint = true; > + DispatchEvent(&willPaintEvent, status); Is it really safe to change widget geometry here (and where you call DispatchDidPaint)? @@ +1103,5 @@ > #endif //MOZ_ENABLE_QTMOBILITY > > + status = DispatchEvent(&event); > + DispatchDidPaint(this); > + aPainter->beginNativePainting(); maybe this should be "endNativePainting"? And maybe that should happen before DispatchDidPaint?

Fixed endNativePainting. > Is it really safe to change widget geometry here Did not get why geometry should change here? > (and where you call DispatchDidPaint)? I call it at the end of GL painting and at the end of DoPaint (software rendering)

Err, forgot to fix order

Comment on attachment 606938 [details] [diff] [review] Widget Wil/Did Paint Review of attachment 606938 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/qt/nsWindow.cpp @@ +1233,5 @@ > } > > ctx = nsnull; > targetSurface = nsnull; > + DispatchDidPaint(this); You're not setting willSendDidPaint to true for this paint event.

Added WillSendDidPaint flag to software paint. Also not sure what to do about geometry changed in this case... I guess nothing bad should happen Is there are test related to this move/size during paint?

I can't remember. It doesn't happen much anymore since we got rid of almost all child widgets.

Comment on attachment 606949 [details] [diff] [review] Widget Wil/Did Paint Ok, hopefully we can survive with that