Closed
Bug 710824
Opened 13 years ago
Closed 11 years ago
Product download page should handle invalid GET parameters
Categories
(www.mozilla.org :: Information Architecture & UX, defect)
www.mozilla.org
Information Architecture & UX
Tracking
(Not tracked)
RESOLVED
FIXED
Future
People
(Reporter: retornam, Unassigned)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
(deleted),
image/png
|
Details |
STR:
1) Visit http://www-dev.allizom.org/en-US/products/download.html in Firefox 8
2) Notice that the page is broken
Comment 1•13 years ago
|
||
Yikes!
James - can you take a look?
Assignee: nobody → jlong
Target Milestone: --- → 4.11
Comment 2•13 years ago
|
||
The layout could use a tweak, but this page is never linked to directly without the URL variables to trigger an actual download, so no one should actually be seeing this page.
To see this page in it's proper form, try any of the download buttons on mozilla.org/firefox
Comment 3•13 years ago
|
||
This is not production and this is not a valid link to download. How did you arrive on this link?
Comment 4•13 years ago
|
||
Hm, why is the page hooked up to a URL anyway? Anthony's right, one should probably never arrive there.
Updated•13 years ago
|
Assignee: jlong → mozbugs.retornam
Comment 5•13 years ago
|
||
FYI, this page is the one en-US uses for as a transition download page that triggers the download (mostly for metrics)
http://www.mozilla.org/products/download.html?product=firefox-8.0.1&os=linux&lang=en-US
It is used with GET parameters that will trigger the download via javascript.
It's an old page as indicates the /products/ part (back in 2005, our urls for products were /products/firefox/, /products/mozilla1x/, /products/thunderbird/, /products/camino/ ...).
For locales which had this page created several years later, we use a simpler url scheme:
http://www.mozilla.org/fr/download/?product=firefox-8.0.1&os=linux&lang=fr
In PHP, we have for locales a check for the validity of the parameters and if they are malformed or missing, the page redirects to the regular download page:
http://www.mozilla.org/fr/download/
redirects to http://www.mozilla.org/fr/firefox/
I suggest that the old en-US page is updated to have a similar behaviour.
That said, AFAIK we don't expose the URL without it's parameters anywhere therefore end users shouldn't meet this page.
Updated•13 years ago
|
Target Milestone: 4.11 → Future
Comment 6•13 years ago
|
||
Changing the title because it was too dramatic. This is not a serious bug, the page has been that way for months/years.
Updated•13 years ago
|
Summary: Product download page broken on production → Product download page should handle invalid GET parameters
Reporter | ||
Updated•13 years ago
|
Assignee: mozbugs.retornam → nobody
Assignee | ||
Updated•13 years ago
|
Component: www.mozilla.org/firefox → www.mozilla.org
Assignee | ||
Updated•12 years ago
|
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
Updated•11 years ago
|
Blocks: download-buttons
Updated•11 years ago
|
Component: General → Information Architecture & UX
OS: Windows XP → All
Hardware: x86 → All
Comment 8•11 years ago
|
||
My patch in Bug 887940 checks $_GET['product'] to resolve this issue as well.
Comment 9•11 years ago
|
||
This has been fixed in Bug 887940.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•