Closed
Bug 710835
Opened 13 years ago
Closed 13 years ago
Form autocomplete popup list flickers as you type
Categories
(Firefox for Android Graveyard :: General, defect, P2)
Tracking
(firefox11 fixed, firefox12 fixed, fennec11+)
VERIFIED
FIXED
Firefox 12
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Follow-up from bug 695444 comment 14.
Comment 1•13 years ago
|
||
Steps to reproduce:
- Go to http://people.mozilla.org/~mwargers/tests/autocomplete_forms/textinput_form.html
- Tap on the input, type 'abc' and submit the form
- Tap on the input again
- Now type 'b' a couple of times
Notice how the form autocomplete popup keeps appearing and disappearing on every keystroke.
Updated•13 years ago
|
Assignee: nobody → margaret.leibovic
Priority: -- → P3
Assignee | ||
Comment 4•13 years ago
|
||
Changing this to a P2, since I duped bug 711181 to it and that's a P2.
I feel like one patch should fix all the popup flicker problems, but I still have to look into exactly what we need to change.
Priority: P3 → P2
Updated•13 years ago
|
tracking-fennec: --- → 11+
Assignee | ||
Comment 5•13 years ago
|
||
I'm not quite sure why we decided to listen for composition* events instead of input events when we first implemented this - my guess is that input events weren't working properly at the time. In any case, this avoids lots of the problems we were having with compositionupdate events (wrong data strings, firing at the wrong times, etc).
The only issue I see with this is that the popup with suggestions doesn't appear when you first focus the text box, but that's not working right now anyway - we can fix that in another bug.
Attachment #587533 -
Flags: review?(mark.finkle)
Comment 6•13 years ago
|
||
Comment on attachment 587533 [details] [diff] [review]
patch
Glad to see this is working
Attachment #587533 -
Flags: review?(mark.finkle) → review+
Updated•13 years ago
|
status-firefox11:
--- → affected
status-firefox12:
--- → affected
Assignee | ||
Comment 7•13 years ago
|
||
Comment 8•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 12
Comment 9•13 years ago
|
||
Thanks, I verified this is indeed fixed in today's native Fennec build. Also bug 711181 is indeed fixed now, so it was indeed a duplicate.
Status: RESOLVED → VERIFIED
Assignee | ||
Comment 10•13 years ago
|
||
Comment on attachment 587533 [details] [diff] [review]
patch
[Approval Request Comment]
User impact if declined: form autocomplete popups will continue to have lots of problems
Testing completed (on m-c, etc.): verified on Nightly
Risk to taking this patch (and alternatives if risky): input events could have problems again, but they're in a much better state than composition events right now
Attachment #587533 -
Flags: approval-mozilla-aurora?
Comment 11•13 years ago
|
||
Comment on attachment 587533 [details] [diff] [review]
patch
[Triage Comment]
Mobile only - approving for Aurora.
Attachment #587533 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Updated•13 years ago
|
Comment 13•13 years ago
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•