in working towards merging reftest.js with a js module in bug 704509, we should use the FileUtils.jsm and the raw quit logic instead of quit.js and mozillaFileLogger.js.

simple patch, tested on try for all platforms and looks good.

Is the intent to also remove the quit.js and MozillaLogger.js links from reftest.xul ?

yes, that was my fault for not being complete. I will do that later tonight and upload a new patch. Please let me know of there are other concerns.

So I guess the other question is: why are these improvements? I don't know much about the logging stuff either way, so I'll basically take your word for it there... though I'm vaguely curious what the improvement is. As far as the quit code, it effectively looks like you're removing a bunch of code -- the code that checks if it's ok to quit. I suppose that's probably not really needed, so I guess it's fine. Are the old ways problematic for using from a JS module? So r=dbaron if you also: * remove the script elements that point to both unneeded scripts * remove both files from the jar.mn * hg remove quit.js

dbaron, I fixed all your comments as well as some 2 space code in the area I was modifying. I found that the quit code was unnecessary since it was designed to work in non chrome code as well. For the file logger, it made more sense to use an existing .jsm instead of a custom .js file which would need to be imported. Not 100% required, but it makes things cleaner. I plan on landing Monday morning, so if you have any concerns about my comment here, let me know and I will address them. Thanks for the review!

landed on inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/4f44ef4d21fb

Backed out for Android test failures: https://hg.mozilla.org/integration/mozilla-inbound/rev/102720b9401f

relanded on inbound, things are looking good now: https://hg.mozilla.org/integration/mozilla-inbound/rev/21b0f339bf52