Open
Bug 71128
Opened 24 years ago
Updated 11 years ago
replace string comparisons with "offline support level" attribute
Categories
(SeaMonkey :: MailNews: Backend, defect)
Tracking
(Not tracked)
NEW
People
(Reporter: mohanb, Unassigned)
References
Details
(Whiteboard: [patchlove])
Attachments
(3 files, 2 obsolete files)
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Offline : Property Dialogs : Mail Folder & Newsgroup
Need to add Property Dialogs for Mail Folder & Newsgroup.
Comment 1•24 years ago
|
||
*** This bug has been marked as a duplicate of 10877 ***
Status: UNCONFIRMED → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
Reopening -- I think this is for the addition of the proper offline panel within
the properties dialogs. Particular to offline, not naming the overall general
dialog.
Status: RESOLVED → UNCONFIRMED
Resolution: DUPLICATE → ---
Updated•23 years ago
|
Reporter | ||
Comment 3•23 years ago
|
||
Comment 4•23 years ago
|
||
why not have the xul use the same attributes for imap and newsgroups,
offline.selectForOfflineFolder - then you won't need to check both variables
(news and imap), which I think is causing trouble.
Reporter | ||
Comment 5•23 years ago
|
||
Download folder has : "select folder for download" and
Offline folder has : "select this folder for offline use"
Right now if both are checked the value is gettting is stored otherwise not and
vice versa. Now that "Download folder is removed" this would be taken care of
right ?
Comment 6•23 years ago
|
||
there shouldn't be two tabs in the first place - they mean the same thing.
There's already an existing bug for that. I think hwaara's working on that but
you two need to get together because you're going to have conflicts in your
changes, I suspect.
Reporter | ||
Comment 7•23 years ago
|
||
Comment 8•23 years ago
|
||
why do we need selectForOfflineNewsgroup? Why can't the checkbox have the same
element id in either the newsgroup or folder case? Then we wouldn't need that
code that looks at the protocol.
Comment 9•23 years ago
|
||
since I took over the bugs from hwaara...
first of all, the tabbing in the patch is annoying, the agreement is 2 spaces
for it.
I have the xul/js changes done for the following
-remove the download tab
-minor dtd renamings (offline -> offline use)
-character coding into the general tab
-other small xul changes
I can post a patch if you want of what i have
Reporter | ||
Comment 10•23 years ago
|
||
Working on a)same var for mail and news; Ignore the previous attachment.
Doron : can you post the patch?
Comment 11•23 years ago
|
||
bug 78891 has the patch, i cleaned some tabbing too. I can help with any
merging need be
Reporter | ||
Comment 12•23 years ago
|
||
Doron :
Have integrated the following into new patch
-remove the download tab
-minor dtd renamings (offline -> offline use)
-character coding as a separate tab
-UI button size change
-same var for mail & news in Offline tab
Attaching herewith ..
Reporter | ||
Comment 13•23 years ago
|
||
Reporter | ||
Comment 14•23 years ago
|
||
Reporter | ||
Comment 15•23 years ago
|
||
Mail folder and Newsgroup need to have separate IDs so that "wsm_persist" works
fine. So keeping separate IDs. Requesting r=bienvenu
Thanks, Mohan
Comment 16•23 years ago
|
||
I'm still confused - you'll never have a newsgroup property and an imap folder
property dialog up at the same time, right? and they share the same dialog code.
So why do they need two settings? That checkbox is exactly the same - the label
might be different.
Comment 17•23 years ago
|
||
*** Bug 79804 has been marked as a duplicate of this bug. ***
Reporter | ||
Comment 18•23 years ago
|
||
This is what I think, correct me :
Option I -----
a) There are two separate labels one in "pop3,imap"; one in "nntp",
b) so we need two check boxes, with different labels. (only one will be shown)
c) In case, if they have same ID; during "wsm_persist" the state of the first
check box will be remembered; but not the second.
d) so we need two different IDs so that the state of the both would be
remembered.
Option II---------
The other option is if we can set the labels dynamically depending on the
servertype in the OnInit() (with only one check-box) but this means we have to
create a property file; with two labels of text because we will not be
using "dtd" file. (ths is how it is done in menu items right ?)
In this case we will not be able to use "XUL-DTD" architecture.
Opinion ---
The first option is better because it offers flexibility and uniformity for
future additions (like "Use defaults from account settings xxx" etc.)
---------
Comment 19•23 years ago
|
||
forgive my ignorance - when you say remembered, do you mean remembered when you
switch tabs? Or remembered between opening and closing the dialog?
Reporter | ||
Comment 20•23 years ago
|
||
remembered between different instances of the dialog
Select a newsgroup, select "folder Properties"; check it, click ok, dialog gets
dismissed, Select "folder Properties" menu item again, the checked state will be
lost.
Reporter | ||
Comment 21•23 years ago
|
||
requesting r & sr (bienvenu & sspitzer)
Comment 22•23 years ago
|
||
this does not cover 78900 - you're passing in the parent window (which is a
start) but not a progress window.
the state of the dialog does not need to persist across instances of the dialog
(it's wrong for it to do so, in fact). The state of the dialog (or, rather, the
checkbox) is stored in a per-folder flag, and the state of the checkbox is
initialized from the state of the folder flag. That's the whole point of that
checkbox - to be initialized based on the offline folder flag, and to set the
offline folder flag.
Reporter | ||
Comment 23•23 years ago
|
||
1. this does not cover 78900 - passing in the parent window (which is a
start) but not a progress window.
- right.
2. That's the whole point of that checkbox - to be initialized based on the
offline folder flag, and to set the offline folder flag.
-- Let me explain; when there are two check boxes with same ID, whenever(either
first time or second), we set the state of the check box (true or false) it gets
reflected in the first one but not the second. we need 2 check boxes because
labels are different. Hope I am clear.
Reporter | ||
Updated•23 years ago
|
Priority: -- → P2
Reporter | ||
Comment 24•23 years ago
|
||
This covers 67607, 71128, 78989, 79097.
Comment 25•23 years ago
|
||
to furthur confuse, 78891 has a new patch (one with code change, the other with
tab removal from folderProps.js)
Comment 26•23 years ago
|
||
Setting target milestone to 0.9.2 (check it in anytime, even before, when the
tree is open for). Per PDT triage.
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Reporter | ||
Updated•23 years ago
|
Whiteboard: Have a fix, requesting review
Comment 27•23 years ago
|
||
the 17:03 patch looks wrong, however, since it ignores the news download id, so
I assume you're checking in the 15:05 js diffs?
Reporter | ||
Comment 28•23 years ago
|
||
I am thinking of 05/09/01 18:26; with different ID's for mail and news.
Comment 29•23 years ago
|
||
whoops, my mistake. OK, please remove the "select folder for offline" stuff for
pop folders/servers - that doesn't make sense. Pop folders are offline by
definition.
Reporter | ||
Comment 30•23 years ago
|
||
Comment 31•23 years ago
|
||
Mohan, you should not duplicate the work done in bug 78891, which you have done
with this latest patch.
Furthermore, you should probably wait and land this fix after that bug is fixed
(since it already has r=, and is more complicated than this patch).
This bug now depends on 78891.
Depends on: 78891
Reporter | ||
Comment 32•23 years ago
|
||
ok, I will follow this up after 78891. thanks, mohan.
Comment 33•23 years ago
|
||
yes, wait until #78891 has landed.
there's another bug that when fixed, will help simplify this code.
instead of doing string compares, we should be using an attribute on the
nsIMsgFolder for if a given folder has offline capabilities, instead of doing
string compares with the server type.
#79239 covers the infrastructure work that you'll need and I'll do it for you
by early 0.9.2
Depends on: 79239
Reporter | ||
Updated•23 years ago
|
Whiteboard: Have a fix, requesting review
Reporter | ||
Updated•23 years ago
|
Whiteboard: [PDT+] → [PDT+] Planning for check-in by FRI : 06/22
Reporter | ||
Updated•23 years ago
|
Whiteboard: [PDT+] Planning for check-in by FRI : 06/22 → [PDT+]
Comment 35•23 years ago
|
||
No current comments. Have we given up on this one?
Reporter | ||
Comment 36•23 years ago
|
||
targeting limbo builds;
Target Milestone: mozilla0.9.2 → mozilla0.9.3
Reporter | ||
Comment 37•23 years ago
|
||
When this bug was initially opened, it was meant for the basic functionality of
"Offline Property Dialogs : mail & newsgroup";
All that functionality got already into the tree with other bugs;
remaining work :
1. replace string comparisions with "offline support level" attribute;
This is only internal change and would not be effecting the functionality; so
moved to mozilla 0.9.3
thanks, mohan.
Reporter | ||
Updated•23 years ago
|
Whiteboard: [PDT+] → [PDT+] moved to m0.9.3 as only internal string change
Comment 38•23 years ago
|
||
updating summary, based on mohan's comments.
if that is all this bug is anymore, this is no longer PDT+ / nsbeta+
Severity: normal → minor
Keywords: nsbeta1+
Summary: Offline : Property Dialogs : Mail Folder & Newsgroup → replace string comparisions with "offline support level" attribute
Whiteboard: [PDT+] moved to m0.9.3 as only internal string change
Comment 39•23 years ago
|
||
Doesn't look like this is getting fixed before the freeze tonight.
Pushing out a milestone. Please correct if I'm mistaken.
Target Milestone: mozilla0.9.3 → mozilla0.9.4
Updated•23 years ago
|
Target Milestone: mozilla0.9.4 → mozilla0.9.5
Comment 40•23 years ago
|
||
Reassigning 0.9.4 Offline IMAP UI bugs to David; TFV 0.9.5.
Assignee: mohanb → bienvenu
Comment 41•23 years ago
|
||
not esential - moving to .9.7
Status: NEW → ASSIGNED
Target Milestone: mozilla0.9.5 → mozilla0.9.7
Updated•23 years ago
|
Target Milestone: mozilla0.9.7 → mozilla1.0.1
Updated•20 years ago
|
Product: Browser → Seamonkey
Updated•16 years ago
|
Status: ASSIGNED → NEW
Priority: P2 → --
QA Contact: grylchan → offline
Target Milestone: mozilla1.0.1 → ---
Comment 42•16 years ago
|
||
This bug is being marked EXPIRED as it has seen no activity in a very long time.
If you think that the issue reported might still be relevant, please test with a recent release of SeaMonkey and if the problem persists feel free to re-open the report. Thank you.
http://www.seamonkey-project.org/
Status: NEW → RESOLVED
Closed: 24 years ago → 16 years ago
Resolution: --- → EXPIRED
Comment 43•16 years ago
|
||
Bulk reopening incorrectly expired bugs - no activity does not constitute no bug - these need proper checking.
Status: RESOLVED → REOPENED
Resolution: EXPIRED → ---
Updated•15 years ago
|
Attachment #33762 -
Attachment description: Proposed Patch for : 78900, 79804, 78891, 67607, 71128, 79097 → Proposed Patch for : 78900, 79804, 78891, 67607, 71128, 79097
[Same as previous patch]
Attachment #33762 -
Attachment is obsolete: true
Updated•15 years ago
|
Attachment #33750 -
Attachment is obsolete: true
Updated•15 years ago
|
Status: REOPENED → NEW
Whiteboard: [patchlove]
Updated•15 years ago
|
Assignee: bienvenu → nobody
QA Contact: offline → mailnews-backend
Updated•11 years ago
|
Summary: replace string comparisions with "offline support level" attribute → replace string comparisons with "offline support level" attribute
You need to log in
before you can comment on or make changes to this bug.
Description
•