Offline : Property Dialogs : Mail Folder & Newsgroup Need to add Property Dialogs for Mail Folder & Newsgroup.

*** This bug has been marked as a duplicate of 10877 ***

Reopening -- I think this is for the addition of the proper offline panel within the properties dialogs. Particular to offline, not naming the overall general dialog.

why not have the xul use the same attributes for imap and newsgroups, offline.selectForOfflineFolder - then you won't need to check both variables (news and imap), which I think is causing trouble.

Download folder has : "select folder for download" and Offline folder has : "select this folder for offline use" Right now if both are checked the value is gettting is stored otherwise not and vice versa. Now that "Download folder is removed" this would be taken care of right ?

there shouldn't be two tabs in the first place - they mean the same thing. There's already an existing bug for that. I think hwaara's working on that but you two need to get together because you're going to have conflicts in your changes, I suspect.

why do we need selectForOfflineNewsgroup? Why can't the checkbox have the same element id in either the newsgroup or folder case? Then we wouldn't need that code that looks at the protocol.

since I took over the bugs from hwaara... first of all, the tabbing in the patch is annoying, the agreement is 2 spaces for it. I have the xul/js changes done for the following -remove the download tab -minor dtd renamings (offline -> offline use) -character coding into the general tab -other small xul changes I can post a patch if you want of what i have

Working on a)same var for mail and news; Ignore the previous attachment. Doron : can you post the patch?

bug 78891 has the patch, i cleaned some tabbing too. I can help with any merging need be

Doron : Have integrated the following into new patch -remove the download tab -minor dtd renamings (offline -> offline use) -character coding as a separate tab -UI button size change -same var for mail & news in Offline tab Attaching herewith ..

Mail folder and Newsgroup need to have separate IDs so that "wsm_persist" works fine. So keeping separate IDs. Requesting r=bienvenu Thanks, Mohan

I'm still confused - you'll never have a newsgroup property and an imap folder property dialog up at the same time, right? and they share the same dialog code. So why do they need two settings? That checkbox is exactly the same - the label might be different.

*** Bug 79804 has been marked as a duplicate of this bug. ***

This is what I think, correct me : Option I ----- a) There are two separate labels one in "pop3,imap"; one in "nntp", b) so we need two check boxes, with different labels. (only one will be shown) c) In case, if they have same ID; during "wsm_persist" the state of the first check box will be remembered; but not the second. d) so we need two different IDs so that the state of the both would be remembered. Option II--------- The other option is if we can set the labels dynamically depending on the servertype in the OnInit() (with only one check-box) but this means we have to create a property file; with two labels of text because we will not be using "dtd" file. (ths is how it is done in menu items right ?) In this case we will not be able to use "XUL-DTD" architecture. Opinion --- The first option is better because it offers flexibility and uniformity for future additions (like "Use defaults from account settings xxx" etc.) ---------

forgive my ignorance - when you say remembered, do you mean remembered when you switch tabs? Or remembered between opening and closing the dialog?

remembered between different instances of the dialog Select a newsgroup, select "folder Properties"; check it, click ok, dialog gets dismissed, Select "folder Properties" menu item again, the checked state will be lost.

requesting r & sr (bienvenu & sspitzer)

this does not cover 78900 - you're passing in the parent window (which is a start) but not a progress window. the state of the dialog does not need to persist across instances of the dialog (it's wrong for it to do so, in fact). The state of the dialog (or, rather, the checkbox) is stored in a per-folder flag, and the state of the checkbox is initialized from the state of the folder flag. That's the whole point of that checkbox - to be initialized based on the offline folder flag, and to set the offline folder flag.

1. this does not cover 78900 - passing in the parent window (which is a start) but not a progress window. - right. 2. That's the whole point of that checkbox - to be initialized based on the offline folder flag, and to set the offline folder flag. -- Let me explain; when there are two check boxes with same ID, whenever(either first time or second), we set the state of the check box (true or false) it gets reflected in the first one but not the second. we need 2 check boxes because labels are different. Hope I am clear.

This covers 67607, 71128, 78989, 79097.

to furthur confuse, 78891 has a new patch (one with code change, the other with tab removal from folderProps.js)

Setting target milestone to 0.9.2 (check it in anytime, even before, when the tree is open for). Per PDT triage.

the 17:03 patch looks wrong, however, since it ignores the news download id, so I assume you're checking in the 15:05 js diffs?

I am thinking of 05/09/01 18:26; with different ID's for mail and news.

whoops, my mistake. OK, please remove the "select folder for offline" stuff for pop folders/servers - that doesn't make sense. Pop folders are offline by definition.

Mohan, you should not duplicate the work done in bug 78891, which you have done with this latest patch. Furthermore, you should probably wait and land this fix after that bug is fixed (since it already has r=, and is more complicated than this patch). This bug now depends on 78891.

ok, I will follow this up after 78891. thanks, mohan.

yes, wait until #78891 has landed. there's another bug that when fixed, will help simplify this code. instead of doing string compares, we should be using an attribute on the nsIMsgFolder for if a given folder has offline capabilities, instead of doing string compares with the server type. #79239 covers the infrastructure work that you'll need and I'll do it for you by early 0.9.2

PDT+ per 6/12 mtg.

No current comments. Have we given up on this one?

targeting limbo builds;

When this bug was initially opened, it was meant for the basic functionality of "Offline Property Dialogs : mail & newsgroup"; All that functionality got already into the tree with other bugs; remaining work : 1. replace string comparisions with "offline support level" attribute; This is only internal change and would not be effecting the functionality; so moved to mozilla 0.9.3 thanks, mohan.

updating summary, based on mohan's comments. if that is all this bug is anymore, this is no longer PDT+ / nsbeta+

Doesn't look like this is getting fixed before the freeze tonight. Pushing out a milestone. Please correct if I'm mistaken.

Reassigning 0.9.4 Offline IMAP UI bugs to David; TFV 0.9.5.

not esential - moving to .9.7

This bug is being marked EXPIRED as it has seen no activity in a very long time. If you think that the issue reported might still be relevant, please test with a recent release of SeaMonkey and if the problem persists feel free to re-open the report. Thank you. http://www.seamonkey-project.org/

Bulk reopening incorrectly expired bugs - no activity does not constitute no bug - these need proper checking.