Closed
Bug 711679
Opened 13 years ago
Closed 13 years ago
Send background version checks to new domain
Categories
(Toolkit :: Add-ons Manager, defect)
Toolkit
Add-ons Manager
Tracking
()
RESOLVED
FIXED
mozilla13
People
(Reporter: fligtar, Assigned: Unfocused)
References
Details
(Whiteboard: [fixed-in-fx-team])
Attachments
(1 file)
(deleted),
patch
|
mossop
:
review+
darktrojan
:
review+
|
Details | Diff | Splinter Review |
To help IT handle high load, we'd like the background update pings to be sent to a separate domain so that they can be turned off without affecting upgrade compatibility and other more important services. This should involve cloning extensions.update.url and replacing the domain to be versioncheck-bg.addons.mozilla.org and using that setting when it's a background check. Note that there is probably some trickery around add-ons that use a custom updateURL -- we shouldn't force them to set this property if possible, it should continue to work as it currently does and not ping us.
Assignee | ||
Comment 1•13 years ago
|
||
Which domain should hotfix checks use? It happens during the periodic background update check, but it's more important than a normal addon update.
Assignee: nobody → bmcbride
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•13 years ago
|
||
Until I get an answer to comment 1, this assumes the hotfix checks should use the new domain. But that's really simple to revert.
Attachment #599514 -
Flags: review?(geoff)
Attachment #599514 -
Flags: review?(dtownsend+bugmail)
Reporter | ||
Comment 3•13 years ago
|
||
I don't think we need to special case the hotfix add-on unless it's super easy to do. My hope is that we will only ever need to use this rarely and for brief intervals.
Updated•13 years ago
|
Attachment #599514 -
Flags: review?(geoff) → review+
Assignee | ||
Comment 4•13 years ago
|
||
(In reply to Justin Scott [:fligtar] from comment #3) > I don't think we need to special case the hotfix add-on unless it's super > easy to do. My hope is that we will only ever need to use this rarely and > for brief intervals. It is super-easy to do - hotfixes have their own update logic, so it's a one-line fix to change which preference to use (I had to change that one line to make it use the new domain). Even the test was a one-line fix. So it's only a matter which is more appropriate.
Updated•13 years ago
|
Attachment #599514 -
Flags: review?(dtownsend+bugmail) → review+
Assignee | ||
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/b73fbdb5a5b5
Flags: in-testsuite+
Flags: in-litmus-
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla13
Assignee | ||
Comment 6•13 years ago
|
||
For future reference: That patch made it so hotfix checks go to the new domain.
Comment 7•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/b73fbdb5a5b5
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•