Closed
Bug 712065
Opened 13 years ago
Closed 13 years ago
SVG image is only partially visible
Categories
(Firefox for Android Graveyard :: General, defect, P3)
Tracking
(firefox11 verified, firefox12 verified, fennec11+)
VERIFIED
FIXED
Firefox 12
People
(Reporter: mpk, Assigned: kats)
Details
(Whiteboard: [MTD])
Attachments
(2 files)
(deleted),
image/svg+xml
|
Details | |
(deleted),
patch
|
mfinkle
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
When loading an SVG image, Fennec at first sizes the initial viewport correctly.
But it then zooms in so the image is only partially visible.
You can zoom further in, but you can't zoom out.
Aurora, Beta and the releases seem to work okay.
Updated•13 years ago
|
Whiteboard: [MTD]
Updated•13 years ago
|
Assignee: nobody → bugmail.mozilla
Priority: -- → P3
Comment 1•13 years ago
|
||
This might be related to the way we get the document size. SVG documents might need to use a different method.
In the old days we used this code:
http://hg.mozilla.org/releases/mobile-1.1/file/b28b396278b1/chrome/content/BrowserView.js#l170
if (cdoc instanceof SVGDocument) {
let rect = cdoc.rootElement.getBoundingClientRect();
return [Math.ceil(rect.width), Math.ceil(rect.height)];
}
In the current code, we might need to add a check like this here:
http://mxr.mozilla.org/mozilla-central/source/mobile/android/chrome/content/browser.js#1310
Updated•13 years ago
|
tracking-fennec: --- → 11+
Assignee | ||
Updated•13 years ago
|
OS: All → Android
Assignee | ||
Comment 2•13 years ago
|
||
Did the thing from comment #1 but slightly modified so that the page is large enough to display the SVG centered.
Attachment #590869 -
Flags: review?(mark.finkle)
Comment 3•13 years ago
|
||
Comment on attachment 590869 [details] [diff] [review]
Patch
A little strange but OK. Have you tried loading a few different SVG images using this patch? Wikipedia usually has a bunch.
Attachment #590869 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•13 years ago
|
||
I tried loading a bunch of sample SVGs I found using google. I'll try some Wikipedia ones too before landing.
Try push: https://tbpl.mozilla.org/?tree=Try&rev=088b95dce8e0
Assignee | ||
Comment 5•13 years ago
|
||
Wikipedia SVGs also seem to render fine.
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c0e02c455fd
Comment 6•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•13 years ago
|
||
Comment on attachment 590869 [details] [diff] [review]
Patch
[Approval Request Comment]
Regression caused by (bug #): none
User impact if declined: loading SVG documents sometimes shows them cropped and generally acts weird
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): mobile only
Attachment #590869 -
Flags: approval-mozilla-aurora?
Comment 8•13 years ago
|
||
Comment on attachment 590869 [details] [diff] [review]
Patch
[Triage Comment]
Mobile only - approved for Aurora.
Attachment #590869 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 9•13 years ago
|
||
Comment 10•13 years ago
|
||
Verified fixed on Nightly 13.0a1 (2012-02-02)
Aurora 12.0a2 (2012-02-02)
Device: Samsung Galaxy S2 (Android 2.3.4)
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•