Closed Bug 712285 Opened 13 years ago Closed 13 years ago

(tabs on top) throbber very close to edge

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird11 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 12.0
Tracking Flags:
Tracking Status
thunderbird11 --- fixed

People

(Reporter: andreasn, Assigned: andreasn)

References

Details

Attachments

(1 file, 2 obsolete files)

throbber patch v3
(deleted), patch
mconley
: review+
mconley
: ui-review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review
Followup to bug #644169 (comment 155). Siddharth noted that the throbber in the tab is very close to the edge of the tab.
Depends on: tb-tabsontop
The text also moves a couple of pixels to the left when the tab is loading, and the throbber is very big itself. Firefox have two throbbers of nicer size. What one should we take? Both?
Assignee: nobody → nisses.mail
Status: NEW → ASSIGNED
Attached patch Throbber patch (obsolete) (deleted) — — Splinter Review
This patch only positions the throbber like the icon. So no more text move. It's up to you if you want change the trobber.
Attachment #584079 - Flags: review?(nisses.mail)
Attached patch updated throbber patch (obsolete) (deleted) — — Splinter Review
This adds the green styled throbber from Firefox to Richards patch. This throbber is more in style with the Win7 cursor loader graphics.
Attachment #584079 - Attachment is obsolete: true
Attachment #584079 - Flags: review?(nisses.mail)
Attached patch throbber patch v3 (deleted) — — Splinter Review
This also changes the throbber in the all tabs dropdown.
Attachment #586120 - Attachment is obsolete: true
Attachment #586137 - Flags: review?(mconley)
Comment on attachment 586137 [details] [diff] [review] throbber patch v3 That's gorgeous! Great work, Andreas! I'm really quite happy with that. :) -Mike
Attachment #586137 - Flags: ui-review+
Attachment #586137 - Flags: review?(mconley)
Attachment #586137 - Flags: review+
Comment on attachment 586137 [details] [diff] [review] throbber patch v3 We'll want this for TB 11 as well.
Attachment #586137 - Flags: approval-comm-aurora?
Committed to comm-central as http://hg.mozilla.org/comm-central/rev/7fd685d744ac
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 12.0
Attachment #586137 - Flags: approval-comm-aurora? → approval-comm-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: