Closed
Bug 712766
Opened 13 years ago
Closed 13 years ago
Replace the buildid by an easily readable build date in about:
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox11 verified)
VERIFIED
FIXED
Firefox 12
Tracking | Status | |
---|---|---|
firefox11 | --- | verified |
People
(Reporter: steffen.wilberg, Assigned: steffen.wilberg)
References
Details
Attachments
(2 files)
(deleted),
patch
|
mfinkle
:
review+
asa
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
(deleted),
image/png
|
Details |
At the bottom of about:, we display the buildid.
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20111221 Firefox/12.0a1 Fennec/12.0a1
At the top of about:, we already display the version, so we don't have to repeat it three times. We also know that we're running Mozilla/Gecko/Firefox/Fennec/whatever on Android. The only interesting part is the build date. On Nightly or Aurora, I want to know if I'm a couple of days or weeks behind.
Desktop Firefox just displays the build date after the version for Nightly and Aurora builds:
12.0a1 (2011-12-21)
Because of space contraints (the logo is so big), I propose to display it like this:
12.0a1
(2011-12-21)
Assignee | ||
Comment 1•13 years ago
|
||
Stolen from http://mxr.mozilla.org/mozilla-central/source/browser/base/content/aboutDialog.js#70 plus getting the version from the preprocessor plus the <hr> tag.
Attachment #583619 -
Flags: review?(mark.finkle)
Assignee | ||
Comment 2•13 years ago
|
||
(I didn't hack in the update button in this self-made build)
Comment 3•13 years ago
|
||
Comment on attachment 583619 [details] [diff] [review]
patch
Looks good and removing the UA seems like a good thing too. We can always add that part back if someone really wants it.
Attachment #583619 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Thanks for the quick review, as always!
http://hg.mozilla.org/integration/mozilla-inbound/rev/a376707b4efb
Target Milestone: --- → Firefox 12
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Updated•13 years ago
|
Attachment #583619 -
Flags: approval-mozilla-aurora?
Updated•13 years ago
|
Attachment #583619 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•13 years ago
|
||
status-firefox11:
--- → fixed
Comment 7•13 years ago
|
||
Verified with:
Mozilla/5.0 (Android; Linux armv7l; rv:11.0a2) Gecko/20111228 Firefox/11.0a2
Fennec/11.0a2
Mozilla/5.0 (Android; Linux armv7l; rv:12.0a1) Gecko/20111228 Firefox/12.0a1
Fennec/12.0a1
HTC Desire Z (Android 2.3)
BuildID is displayed at the top of the page in the following format:
12.0a1
(2011-12-28)
and for Aurora:
11.0a2
(2011-12-28)
Status: RESOLVED → VERIFIED
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•