To do this, we need to clean up browser/installer/package-manifest.in, then set MOZ_PKG_FATAL_WARNINGS = 1 before including packager.mk in browser/installer/Makefile.in.

Let's prepare for when (new!) blockers are fixed.

Comment on attachment 588077 [details] [diff] [review] (Av1) Make packager.pm missing file warnings fatal on Firefox [Checked in: Comment 16] Review of attachment 588077 [details] [diff] [review]: ----------------------------------------------------------------- Assuming this passes on try, r=me. Thanks for doing this.

(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #2) > Assuming this passes on try Exactly what I had in progress ;-) https://tbpl.mozilla.org/?tree=Try&rev=0f7ff1139bde

(In reply to Serge Gautherie (:sgautherie) from comment #3) > https://tbpl.mozilla.org/?tree=Try&rev=0f7ff1139bde Succeeded again on Try: https://tbpl.mozilla.org/?tree=Try&rev=acbbd1d961eb

https://tbpl.mozilla.org/?rev=7f540f758671 Win opt, Win pgo, Win debug, Win64 opt and Win64 pgo succeeded. V.Fixed

(In reply to Serge Gautherie (:sgautherie) from comment #7) > Win opt, Win pgo, Win debug, Win64 opt and Win64 pgo succeeded. All builds succeeded: that comment was related to bug 712528...

Comment on attachment 588077 [details] [diff] [review] (Av1) Make packager.pm missing file warnings fatal on Firefox [Checked in: Comment 16] [Approval Request Comment] Regression caused by (bug #): (enhancement) User impact if declined: None, but these warnings (usually) remain unnoticed. Testing completed (on m-c, etc.): try, m-i, m-c. Risk to taking this patch (and alternatives if risky): None, buildtime-only. String changes made by this patch: None.

See bug 736739 where this breaks packaging on official builds.

(In reply to Bob Clary [:bc:] from comment #10) > See bug 736739 where this breaks packaging on official builds. This was wrong as the bug is with --disable-installer builds. thanks to khuey for the identification.

Backed out in https://hg.mozilla.org/mozilla-central/rev/da5e8f6a44bd We build RPM nightlies which build with --disable-updater, which was also broken by this.

(In reply to Phil Ringnalda (:philor) from comment #12) > We build RPM nightlies which build with --disable-updater, which was also > broken by this. I filed bug 736770, thanks to khuey who gave some missing details.

Ftr, https://tbpl.mozilla.org/?tree=Try&rev=a01ca126fa5c succeeded with --disable-crashreporter . (package-manifest.in has an '#ifdef MOZ_CRASHREPORTER' ;-))

Comment on attachment 588077 [details] [diff] [review] (Av1) Make packager.pm missing file warnings fatal on Firefox [Checked in: Comment 16] https://hg.mozilla.org/mozilla-central/rev/cc552c8892cc

https://tbpl.mozilla.org/?onlyunstarred=1&rev=cc552c8892cc V.Fixed

With my mozconfig I get: Warning: package error or possible missing or unnecessary file: bin/libnspr4.so (package-manifest, 33). Warning: package error or possible missing or unnecessary file: bin/libplc4.so (package-manifest, 34). Warning: package error or possible missing or unnecessary file: bin/libplds4.so (package-manifest, 35) Warning: package error or possible missing or unnecessary file: bin/components/necko_wifi.xpt (package-manifest, 146). Warning: package error or possible missing or unnecessary file: bin/components/nsSafebrowsingApplication.manifest (package-manifest, 311). Warning: package error or possible missing or unnecessary file: bin/components/nsSafebrowsingApplication.js (package-manifest, 312). Warning: package error or possible missing or unnecessary file: bin/components/nsURLClassifier.manifest (package-manifest, 313). Warning: package error or possible missing or unnecessary file: bin/components/nsUrlClassifierHashCompleter.js (package-manifest, 314). Warning: package error or possible missing or unnecessary file: bin/components/nsUrlClassifierListManager.js (package-manifest, 315). Warning: package error or possible missing or unnecessary file: bin/components/nsUrlClassifierLib.js (package-manifest, 316). Warning: package error or possible missing or unnecessary file: bin/components/url-classifier.xpt (package-manifest, 317). Warning: package error or possible missing or unnecessary file: bin/libfreebl3.so (package-manifest, 394). Warning: package error or possible missing or unnecessary file: bin/libnss3.so (package-manifest, 395). Warning: package error or possible missing or unnecessary file: bin/libnssckbi.so (package-manifest, 396). Warning: package error or possible missing or unnecessary file: bin/libnssdbm3.so (package-manifest, 397). Warning: package error or possible missing or unnecessary file: bin/libnssutil3.so (package-manifest, 398). Warning: package error or possible missing or unnecessary file: bin/libsmime3.so (package-manifest, 399). Warning: package error or possible missing or unnecessary file: bin/libsoftokn3.so (package-manifest, 400). Warning: package error or possible missing or unnecessary file: bin/libssl3.so (package-manifest, 401). Wouldn't it have been wiser to make the missing file warnings fatal _after_ testing confirmed that nothing is broken accidentally?

(In reply to Octoploid from comment #19) > With my mozconfig I get: Please don't spam this bug: file a blocking one for each option and related failures. > Wouldn't it have been wiser to make the missing file warnings fatal _after_ > testing confirmed that nothing is broken accidentally? Are you volunteering to do that testing?

(In reply to Serge Gautherie (:sgautherie) from comment #20) > (In reply to Octoploid from comment #19) > > > With my mozconfig I get: > > Please don't spam this bug: file a blocking one for each option and related > failures. Reporting build failures caused by your patch is not spam. Asking me to sort through the mess you have created is naive. > > Wouldn't it have been wiser to make the missing file warnings fatal _after_ > > testing confirmed that nothing is broken accidentally? > > Are you volunteering to do that testing? I just did that testing and reported my findings above.

Comment on attachment 588077 [details] [diff] [review] (Av1) Make packager.pm missing file warnings fatal on Firefox [Checked in: Comment 16] [Triage Comment] No user impact, therefore no reason to uplift this build behavior change.

Backing out this bug fixes bug 737821.

For a reason i dont understand this broke seamonkey 2.10 packaging, while it is targeted for gecko 14/seamonkey 2.11.. investigating and filing followup bugs..