Closed
Bug 713269
Opened 13 years ago
Closed 13 years ago
Use Asynchronous Favicons API for PlacesUtils.jsm
Categories
(Toolkit :: Places, defect)
Toolkit
Places
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: felix, Assigned: felix)
References
Details
(Whiteboard: [snappy])
Attachments
(1 file)
|
(deleted),
patch
|
mak
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:8.0.1) Gecko/20100101 Firefox/8.0.1
Build ID: 20111120135848
Actual results:
PlacesUtils.jsm uses sync favicons apis (nsIFaviconService)
Expected results:
PlacesUtils.jsm should use async favicons apis (mozIAsyncFavicons)
|
Assignee | |
Comment 1•13 years ago
|
||
Summary of Changes:
- setAndLoad -> setAndFetch
- setFaviconData -> replaceFaviconData
- nsIFaviconService -> mozIAsyncFavicons
Attachment #584091 -
Flags: review?(mak77)
|
||
Updated•13 years ago
|
Component: Form Manager → Places
QA Contact: form.manager → places
|
||
Updated•13 years ago
|
Blocks: asyncFaviconCallers
|
|
||
Updated•13 years ago
|
Assignee: nobody → felix.the.cheshire.cat
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
|
|
||
Comment 2•13 years ago
|
||
Comment on attachment 584091 [details] [diff] [review]
Use Asynchronous Favicons API for PlacesUtils.jsm
Review of attachment 584091 [details] [diff] [review]:
-----------------------------------------------------------------
please get a try run with the patch before pushing, since I'd not want that there is some test relying on the synchronous behavior that needs some fix
Attachment #584091 -
Flags: review?(mak77) → review+
|
|
||
Comment 3•13 years ago
|
||
any news?
|
|
Assignee | |
Comment 4•13 years ago
|
||
Just got my commit access amended. Will push this to try and then hopefully to mc tonight...
|
|
Assignee | |
Comment 5•13 years ago
|
||
|
||
Comment 6•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
||
Updated•13 years ago
|
Whiteboard: [snappy]
You need to log in
before you can comment on or make changes to this bug.
Description
•