Closed
Bug 713480
Opened 13 years ago
Closed 9 years ago
Compressed entries stored as files are padded with zero bytes to the length of uncompressed size
Categories
(Core :: Networking: Cache, defect)
Core
Networking: Cache
Tracking
()
RESOLVED
WONTFIX
mozilla12
People
(Reporter: michal, Assigned: michal)
References
Details
Attachments
(1 file)
(deleted),
patch
|
bjarne
:
review+
|
Details | Diff | Splinter Review |
This is caused by fallocating of separate files.
http://hg.mozilla.org/mozilla-central/annotate/798b00a6fe29/netwerk/cache/nsDiskCacheStreams.cpp#l739
Assignee | ||
Comment 1•13 years ago
|
||
Maybe we should also bump a cache version to get rid of these oversized entries?
Attachment #584294 -
Flags: review?(jduell.mcbugs)
Assignee | ||
Comment 2•13 years ago
|
||
Comment on attachment 584294 [details] [diff] [review]
fix
Jason seems to be busy, requesting Bjarne.
Attachment #584294 -
Flags: review?(jduell.mcbugs) → review?(bjarne)
Comment 3•13 years ago
|
||
Comment on attachment 584294 [details] [diff] [review]
fix
Review of attachment 584294 [details] [diff] [review]:
-----------------------------------------------------------------
Ok, assuming it passes tryserver. Let's not worry about the cache-bump here - I believe that will happen in any case e.g. as the solution to bug #715198
Attachment #584294 -
Flags: review?(bjarne) → review+
Assignee | ||
Comment 4•13 years ago
|
||
Whiteboard: [inbound]
Target Milestone: --- → mozilla12
Comment 5•13 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/4f2f486f898f - apparently test_bug650995.js liked that padding, and permanently fails like https://tbpl.mozilla.org/php/getParsedLog.php?id=8446297&tree=Mozilla-Inbound without it.
Whiteboard: [inbound]
Comment 6•9 years ago
|
||
another case of an almost landed patch.. michal, should this bug be finished up or wontfixed?
Flags: needinfo?(michal.novotny)
Whiteboard: [necko-backlog]
Assignee | ||
Comment 7•9 years ago
|
||
The patch wasn't needed because cache compression was never turned on. It isn't implemented in the new cache at all and probably will never be, so WONTFIX.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(michal.novotny)
Resolution: --- → WONTFIX
Whiteboard: [necko-backlog]
You need to log in
before you can comment on or make changes to this bug.
Description
•