Closed Bug 71390 Opened 24 years ago Closed 24 years ago

Safe check usage of GetSelectedLocale()

Categories

(SeaMonkey :: MailNews: Account Configuration, defect)

defect
Not set
critical

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: tao, Assigned: hwaara)

Details

Attachments

(1 file)

Hi: As you might have known that I recently landed a change to separate region-specific resources from UI language resources. As a result, the directory names in bin/defaults/* are also changed. In US build, they become "bin/defaults/profile/US/*" instead of "bin/defaults/profile/en-US/*". Looking at the usage of GetSelectedLocale() in the following code, I believe that the package name, "navigator", should be changed to "global-region". Otherwise, those default files will not be found as expected. http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgServiceProvider.cpp#82 http://lxr.mozilla.org/seamonkey/source/mailnews/local/src/nsNoIncomingServer.cpp#119
Hi, Bhuvan: This is a major problem but easy to fix. Would you please make sure the fix asap? Also, in the description, this line: > In US build, they become > "bin/defaults/profile/US/*" instead of "bin/defaults/profile/en-US/*". Should read as In US build, they become "bin/defaults/isp/US/*" instead of bin/defaults/isp/en-US/*". thx
Severity: normal → critical
Since this bug is critical, I want r= and sr=, so I can check it in ASAP. Taking from racham...
Assignee: racham → hwaara
Keywords: patch, review
The patch, 29077, looks fine!
sr=bienvenu
Fixed checked in @ 03/28/2001 22:13. Forgot to mark this fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verify that the source is in LXR.. :) (I don't know how else to verify this.)
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: