Closed
Bug 71390
Opened 24 years ago
Closed 24 years ago
Safe check usage of GetSelectedLocale()
Categories
(SeaMonkey :: MailNews: Account Configuration, defect)
SeaMonkey
MailNews: Account Configuration
Tracking
(Not tracked)
VERIFIED
FIXED
People
(Reporter: tao, Assigned: hwaara)
Details
Attachments
(1 file)
(deleted),
patch
|
Details | Diff | Splinter Review |
Hi:
As you might have known that I recently landed a change to separate
region-specific resources from UI language resources. As a result, the
directory names in bin/defaults/* are also changed. In US build, they become
"bin/defaults/profile/US/*" instead of "bin/defaults/profile/en-US/*".
Looking at the usage of GetSelectedLocale() in the following code, I believe
that the package name, "navigator", should be changed to "global-region".
Otherwise, those default files will not be found as expected.
http://lxr.mozilla.org/seamonkey/source/mailnews/base/src/nsMsgServiceProvider.cpp#82
http://lxr.mozilla.org/seamonkey/source/mailnews/local/src/nsNoIncomingServer.cpp#119
Hi, Bhuvan:
This is a major problem but easy to fix. Would you please make sure the fix
asap? Also, in the description, this line:
> In US build, they become
> "bin/defaults/profile/US/*" instead of "bin/defaults/profile/en-US/*".
Should read as
In US build, they become "bin/defaults/isp/US/*" instead of
bin/defaults/isp/en-US/*".
thx
Severity: normal → critical
Assignee | ||
Comment 2•24 years ago
|
||
Assignee | ||
Comment 3•24 years ago
|
||
Since this bug is critical, I want r= and sr=, so I can check it in ASAP.
Taking from racham...
Comment 5•24 years ago
|
||
sr=bienvenu
Assignee | ||
Comment 6•24 years ago
|
||
Fixed checked in @ 03/28/2001 22:13. Forgot to mark this fixed.
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 7•24 years ago
|
||
Verify that the source is in LXR.. :)
(I don't know how else to verify this.)
Status: RESOLVED → VERIFIED
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•