the buttons in mac classic are too large.

pink, can you be a little bit more specific here? Which buttons?

all buttons, especially ok/cancel.

I'm unable to replicate this issue. Mac buttons dont look too big to me, and I havent heard this from anyone else. Ill come by Pink's cube and see if I can figure out what he's talking about.

Pinkerton pointed out to me some places where buttons end up to be too tall. Investigating as this size difference is no consisten across all dialogs.

Themes Triage Team marking nsbeta1+

moving to 9.2. I have yet to find the true cause of this bug, and it doesnt look like it will be fixed by friday.

themes triage: moving to 1.0

Here is one easy way to see this. Open the Find in page dialog (command-F). Note that the cancel button looks a little large. Start typing some text, so that the Find button is no longer disabled. Watch the cancel button shrink! The problem is that the OK/cancel pairs are contained in a box and the cancel button doesn't have quite enough margin; hence it gets stretched. Patch fixes this and adjusts the margin to conform to Apple's HIG at http://developer.apple.com/techpubs/mac/HIGOS8Guide/thig-52.html Also removed an unneeded rule that I found in button.css. Finally, despite making the button margins 1px larger I didn't see any _new_ problems with pref panels not fitting.

trying patch right now.

Comment on attachment 59662 [details] [diff] [review] Padding patch r=andreww looks ok to me. Tried it out and it seems to work :)

Comment on attachment 59662 [details] [diff] [review] Padding patch sr=hewitt

patch checked in.

Verified the patch