Joe Drew (not getting mail) Assignee
	Description • 13 years ago

This patch implements text in the Canvas backend, both filled and text-to-path. In a build with the other patches implementing the Cairo backend as well as this patch, we still don't use this code, though, because on OS X we unconditionally do Skia fonts for ScaledFont. We'll need to resolve this problem before we can use this backend.

	Joe Drew (not getting mail) Assignee
	Comment 1 • 13 years ago

This patch overrides OS X using Skia ScaledFonts by default, so this patch can actually be tested.

	Jeff Muizelaar [:jrmuizel]
	Comment 2 • 13 years ago

(In reply to Joe Drew (:JOEDREW!) from comment #0)
> Created attachment 586092 [details] [diff] [review]
> font support
> 
> This patch implements text in the Canvas backend, both filled and
> text-to-path. In a build with the other patches implementing the Cairo
> backend as well as this patch, we still don't use this code, though, because
> on OS X we unconditionally do Skia fonts for ScaledFont. We'll need to
> resolve this problem before we can use this backend.

I plan on resolving this as part of the CG backend landing.

	Jeff Muizelaar [:jrmuizel]
	Comment 3 • 13 years ago

Comment on attachment 586092 [details] [diff] [review]
font support

Review of attachment 586092 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/Types.h
@@ +95,5 @@
>    NATIVE_FONT_DWRITE_FONT_FACE,
>    NATIVE_FONT_GDI_FONT_FACE,
>    NATIVE_FONT_MAC_FONT_FACE,
> +  NATIVE_FONT_SKIA_FONT_FACE,
> +  NATIVE_FONT_GFX_FONT_FACE

NATIVE_FONT_CAIRO_FONT_FACE is preferred.

	Joe Drew (not getting mail) Assignee
	Comment 4 • 13 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/603df6854a52

	Ed Morley [:emorley]
	Comment 5 • 13 years ago

https://hg.mozilla.org/mozilla-central/rev/603df6854a52