Closed
Bug 716090
Opened 13 years ago
Closed 13 years ago
IonMonkey: Invalidate inactive IonScripts
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: dvander, Assigned: dvander)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
cdleary
:
review+
|
Details | Diff | Splinter Review |
We're failing the following tests because we're missing a few IonScripts during invalidation:
ion/callgname.js
ion/setelem-proto.js
ion/setgname.js
ion/invalidation/recursive-invalidate.js
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #586575 -
Flags: review?(christopher.leary)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 586575 [details] [diff] [review]
fix
Review of attachment 586575 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/ion/Ion.cpp
@@ +1004,5 @@
>
> void
> ion::Invalidate(JSContext *cx, const Vector<JSScript *> &invalid)
> {
> + // Add an invalidation reference to all invalidated IonScripts.
Nit: can we add something like "to indicate to to the traversal which frames have been invalidated"?
Attachment #586575 -
Flags: review?(christopher.leary) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
http://hg.mozilla.org/projects/ionmonkey/rev/ef75b074399c
http://hg.mozilla.org/projects/ionmonkey/rev/15f251140365
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•