Brian Smith (:briansmith, :bsmith, use NEEDINFO?) Reporter
	Description • 13 years ago

+++ This bug was initially created as a clone of Bug #630230 +++

Please add the following items to prefixSignatureRegEx:

+  'PL_.*',
+  'PR_.*',
+  '_PR_.*',
+  'LL_.*',
+  '_MD_.*',
+  'PORT_.*',
+  'port_.*',
+  'SEC_.*Item',
+  'SECKEY_.*',
+  'seckey_.*',
+  'CERT_.*',
+  'cert_.*',
+  'SSL_.*',
+  'ssl_.*',
+  'ssl3_.*',
+  'SocketClose',
+  'SocketRead',
+  'SocketWrite',
+  'SocketAvailable',
+  'SocketAvailable64',
+  'SocketSync',
+  'SocketWritev',
+  'SocketConnect',
+  'SocketAccept',
+  'SocketBind',
+  'SocketListen',
+  'SocketShutdown',
+  'SocketRecv',
+  'SocketSend',
+  'SocketPoll',
+  'SocketAcceptRead',
+  'SocketTransmitFile',
+  'SocketGetName',
+  'SocketGetPeerName',

NSPR and NSS are very stable at this point, and it is almost definitely the case that the error is in the caller. Too many bug reports are getting generated for generic things like send() and recv() and it is more useful to differentiate specific callers. Also, we need many of the NSS functions added so we can differentiate SSL-related crashes from DOMCrypt-, BrowserID-, plugin-, and extension-, and malware- related crashes.

	Brian Smith (:briansmith, :bsmith, use NEEDINFO?) Reporter
	Comment 1 • 13 years ago

also, my patch includes "send" and "recv", which I forgot to copy into my comment.

	Brian Smith (:briansmith, :bsmith, use NEEDINFO?) Reporter
	Comment 2 • 13 years ago

This is an add-on to the previous patch, which is needed for Windows since WSASend* and WSARecv* show up under send and recv on Windows.

	Kai Engert (:KaiE:)
	Comment 3 • 13 years ago

I don't understand what this bug is about.

	Ludovic Hirlimann [:Usul]
	Comment 4 • 13 years ago

(In reply to Kai Engert (:kaie) from comment #3)
> I don't understand what this bug is about.

It's about modifying crash-stats.mozilla.org processing to omit the comment 0 signature based on the asumptions that callers are bad. So if element 0 of a stack matches any of the coment 0 regex , it won't be displayed by crash-stats but they'll show the stack element 1 as being 0.

	Scoobidiver (away)
	Comment 5 • 13 years ago

(In reply to Ludovic Hirlimann [:Usul] from comment #4)
> it won't be displayed by crash-stats but they'll show the stack element 1 as
> being 0.
prefixSignatureRegEx displays element 0 and element 1 in the crash signature.

If you want element 0 is ignored, it should be in irrelevantSignatureRegEx.

See https://wiki.mozilla.org/Breakpad/Skip_List_How_To

	Benjamin Smedberg
	Comment 6 • 13 years ago

We shouldn't be suppressing/hiding those frames in the signature, they should be in the append list. It's not always the case that the bug is in the caller, so we want to at least have a quick indication of the full codepath involved.

	Brian Smith (:briansmith, :bsmith, use NEEDINFO?) Reporter
	Comment 7 • 13 years ago

I want the semantics that bsmedberg suggests. AFAICT, that is what my patch does. I definitely do not want to consider those stack frames irrelevant.

	Laura Thomson :laura Assignee
	Comment 8 • 12 years ago

Brian, how did you make these patches?  I'm having a bit of trouble trying to apply them.  

(FWIW we prefer pull requests on github these days, but I appreciate the patch, so I'm trying to make it work.)

	Laura Thomson :laura Assignee
	Comment 9 • 12 years ago

...I managed to get it to apply, but it's bitrotted.  Guess I'll just make my own.

	Laura Thomson :laura Assignee
	Comment 10 • 12 years ago

In 
https://github.com/lauraxt/socorro/commit/f540faab92b3d9d6b5615067aa5ebb9cae867046

	[github robot]
	Comment 11 • 12 years ago

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/f540faab92b3d9d6b5615067aa5ebb9cae867046
Fixes bug 716345, Add stable NSS and NSPR API to the prefix skiplist

	[github robot]
	Comment 12 • 12 years ago

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/1e2d3cf9de1bc6d5fdc652df180fd2ddb82a8fbb
Fixes bug 716345, Add stable NSS and NSPR API to the prefix skiplist

	Laura Thomson :laura Assignee
	Comment 13 • 12 years ago

This should be pushed - Scoobidiver, are you not seeing it in prod?

	Scoobidiver (away)
	Comment 14 • 12 years ago

(In reply to Laura Thomson :laura from comment #13)
> This should be pushed - Scoobidiver, are you not seeing it in prod?
It is in prod of course. I updated depending bugs after the landing because of bug 738225.

	Laura Thomson :laura Assignee
	Comment 15 • 12 years ago

Gotcha, thanks.  Just wanted to check this one was working.

	[github robot]
	Comment 16 • 12 years ago

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/1e2d3cf9de1bc6d5fdc652df180fd2ddb82a8fbb
Fixes bug 716345, Add stable NSS and NSPR API to the prefix skiplist

	[github robot]
	Comment 17 • 12 years ago

Commit pushed to v3-branch at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/1e2d3cf9de1bc6d5fdc652df180fd2ddb82a8fbb
Fixes bug 716345, Add stable NSS and NSPR API to the prefix skiplist