Open
Bug 716410
Opened 13 years ago
Updated 2 years ago
Use calendar specific logging methods in CalDAV provider
Categories
(Calendar :: General, enhancement)
Calendar
General
Tracking
(Not tracked)
NEW
People
(Reporter: sfleiter, Unassigned)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Whiteboard: [patchlove])
Attachments
(1 file, 1 obsolete file)
(deleted),
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Reporter | ||
Updated•13 years ago
|
Reporter | ||
Comment 1•13 years ago
|
||
Attachment #586834 -
Flags: review?(philipp)
Reporter | ||
Comment 2•13 years ago
|
||
diffstat calendar_logging_caldav.patch
calDavCalendar.js | 209 ++++++++++++++++++++++--------------------------------
1 file changed, 88 insertions(+), 121 deletions(-)
Reporter | ||
Comment 3•13 years ago
|
||
The former patch missed 1 cal.ERROR in calDavCalendar.js and the whole calDavRequestHandlers.js file.
New diffstat:
calDavCalendar.js | 209 +++++++++++++++++++----------------------------
calDavRequestHandlers.js | 52 +++++------
2 files changed, 114 insertions(+), 147 deletions(-)
33 lines less of code, all messages correlatable to a specific calendar and grep-able log output seems like an improvement to me.
Attachment #586834 -
Attachment is obsolete: true
Attachment #586834 -
Flags: review?(philipp)
Attachment #586845 -
Flags: review?(philipp)
Comment 4•13 years ago
|
||
Comment on attachment 586845 [details] [diff] [review]
Use calendar specific logging methods in CalDAV provider, including calDavRequestHandlers.js
Does this patch take care of all provider log messages, as ssitter noted in bug 716400? Also, consider LOGverbose as noted in mentioned bug.
The things you changed look good, r=philipp
Attachment #586845 -
Flags: review?(philipp) → review+
Comment 5•13 years ago
|
||
Stefan, any progress update? Is this patch ready for checkin?
Updated•4 years ago
|
Assignee: stefan.fleiter → nobody
Status: ASSIGNED → NEW
Type: defect → enhancement
OS: Linux → All
Hardware: x86_64 → All
Version: Trunk → unspecified
Updated•4 years ago
|
See Also: → https://bugzilla.mozilla.org/show_bug.cgi?id=460075,
https://bugzilla.mozilla.org/show_bug.cgi?id=716400
Whiteboard: [patchlove]
Updated•4 years ago
|
Blocks: tb-logging
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•