Closed
Bug 716541
Opened 13 years ago
Closed 13 years ago
Do not fail build on -Wuninitialized when treating warnings as errors
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla12
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
(deleted),
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #586990 -
Flags: review?(mh+mozilla)
Assignee | ||
Comment 1•13 years ago
|
||
This was requested during the discussion in dev-platform.
Whiteboard: [needs review]
Updated•13 years ago
|
Attachment #586990 -
Flags: review?(mh+mozilla) → review+
Comment 2•13 years ago
|
||
I think this needs s/initialized/uninitialized/
At least, right now when I build with this and FAIL_ON_WARNINGS=1 added in content/smil, I get the following build error when I hit content/smil:
> error: -Werror=initialized: no option -Winitialized
Also, "man g++" confirms that there's no "-Winitialized", but there is "-Wuninitialized"
Comment 3•13 years ago
|
||
(confirmed locally that s/initialized/uninitialized/ fixes the error mentioned in Comment 2 and allows me to build)
Comment 4•13 years ago
|
||
Also, it looks like the existing patch (which I think is broken per comment 2 & comment 3) has already landed:
http://hg.mozilla.org/integration/mozilla-inbound/rev/a477a8579ead
Updated•13 years ago
|
Whiteboard: [needs review]
Comment 5•13 years ago
|
||
Oh, and Mounir pushed a bustage fix after that to do the s/initialized/uninitialized/ already. Cool. That bustage-fix was:
http://hg.mozilla.org/integration/mozilla-inbound/rev/c2a85ff814c8
Summary: Do not fail build on -Winitialized when treating warnings as errors → Do not fail build on -Wuninitialized when treating warnings as errors
Updated•13 years ago
|
Target Milestone: --- → mozilla12
Comment 6•13 years ago
|
||
I seem to be hitting some weird "undefined symbol" issues on our Mac OS X tinderboxen, which (so far) always happen right after a -Wuninitialized warning is printed out. I suspect (but am not sure) that it might be due to GCC 4.2 mishandling "-Werror -Wno-error=uninitialized".
Anyway, I filed bug 716787 on that.
Comment 7•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 8•13 years ago
|
||
and the followup
https://hg.mozilla.org/mozilla-central/rev/c2a85ff814c8
Updated•11 years ago
|
Depends on: Wuninitialized
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•