Closed
Bug 717562
Opened 13 years ago
Closed 6 years ago
Search service should use async XHR instead of DOMParser::parseFromStream
Categories
(Firefox :: Search, defect, P5)
Firefox
Search
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: hsivonen, Unassigned)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Snappy:P2])
nsIDOMParser::parseFromStream needs to go away in order to unblock an XML code path rewrite and in any case chrome code shouldn't be doing synchronous IO on the main thread. Please migrate toolkit/components/search/nsSearchService.js to use asynchronous XHR instead of nsIDOMParser.
Reporter | ||
Updated•13 years ago
|
Whiteboard: [Snappy]
Comment 1•13 years ago
|
||
The search service currently depends on sync IO to fulfill API promises. Bug 699856 (or its followup bugs) is going to try to address that. If you need to unblock bug 717561 before that lands, we can consider moving to Sync XHR, I guess, but I'd like to avoid that.
Reporter | ||
Comment 2•13 years ago
|
||
Sync XHR is worse than nsIDOMParser::parseFromStream. It doesn't make sense to move to sync XHR even as an intermediate step. Let's make this one wait for bug 699856 then.
Depends on: jsonSearchSvc
Updated•13 years ago
|
Assignee: nobody → dteller
Whiteboard: [Snappy] → [Snappy:P2]
Comment 3•13 years ago
|
||
I actually had a prototype of the search service using XHR in some parts. Once bug 699856 + followups have landed, I will get to work on this.
Comment 4•13 years ago
|
||
I actually had a prototype of the search service using XHR in some parts. Once bug 699856 + followups have landed, I will get to work on generalizing this.
Comment 6•8 years ago
|
||
I don't mind helping with this, if it's worth converting parseFromStream over to a sync XHR. Or is it possible to make these parts async while we're at it? From what I gather it doesn't look like it...
Flags: needinfo?(dteller)
Well, as per comment 2, sync XHR is not a good idea. So if you want to make it async, that would be nicer.
Flags: needinfo?(dteller)
Updated•7 years ago
|
Summary: Search service should use async XHR instead of nsIDOMParser::parseFromStream → Search service should use async XHR instead of DOMParser::parseFromStream
Updated•7 years ago
|
Priority: -- → P5
Comment 8•6 years ago
|
||
I can't see any use of this in search in latest mozilla-central
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•