Closed
Bug 717951
Opened 13 years ago
Closed 13 years ago
CrashReporter::AppendAppNotesToCrashReport is not thread-safe
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: ajuma, Assigned: ajuma)
References
Details
Attachments
(1 file)
With off-main-thread-compositing, ScopedGfxFeatureReporter (which calls AppendAppNotesToCrashReport) will be used on the compositor thread. However, ApppendAppNotesToCrashReport isn't thread-safe, since it accesses the global notesField string without any locking.
|
||
Comment 1•13 years ago
|
||
It's never been intended to be threadsafe, so if you need this behavior you'll have to fix it yourself. It shouldn't be perf-critical, so I don't think the locking overhead will hurt.
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → ajuma
|
|
Assignee | |
Comment 2•13 years ago
|
||
This adds locking to prevent concurrent access to notesField.
Attachment #589623 -
Flags: review?(ted.mielczarek)
|
|
||
Updated•13 years ago
|
Attachment #589623 -
Flags: review?(ted.mielczarek) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/4cf430a5716c
Target Milestone: --- → mozilla12
|
||
Comment 4•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/4cf430a5716c
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•