Closed
Bug 718072
Opened 13 years ago
Closed 13 years ago
WeakMaps constructor doesn't always get initialized on the global object
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla12
People
(Reporter: bholley, Assigned: bholley)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
Waldo
:
review+
|
Details | Diff | Splinter Review |
My spidey senses tell me that we could use some consolidation here. But in the mean time, here's the patch.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #588528 -
Flags: review?(jwalden+bmo)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 588528 [details] [diff] [review]
patch v1
Review of attachment 588528 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/vm/GlobalObject.cpp
@@ +49,5 @@
> #include "frontend/BytecodeEmitter.h"
> #include "vm/GlobalObject-inl.h"
>
> #include "jsobjinlines.h"
> +#include "jsweakmap.h"
Could you insert this in the js* non-inlines list above? The current inclusions look a disordered mess, but that's no reason to compound the problem.
Attachment #588528 -
Flags: review?(jwalden+bmo) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/5bc8dcf80474
Assignee: general → bobbyholley+bmo
Target Milestone: --- → mozilla12
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•