Closed
Bug 718189
Opened 13 years ago
Closed 7 years ago
Don't expose source-home-page as a synchronous getter
Categories
(Firefox :: Migration, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: asaf, Unassigned)
References
Details
nsIBrowserProfileMigrator's sourceHomePageURL attribute requires migratros to retrieve it synchronously. This is not so great, and for the safari profile migrator, it also forces us to expose a sync reader in property-list-utils.
Comment 1•13 years ago
|
||
It's also profile-related so I'd prefer if it was a function with an aProfile argument like most others so that the migrator doesn't have to remember the profile that is being migrated.
Reporter | ||
Comment 2•13 years ago
|
||
Fixing this properly requires asyncifying getResources, because the migration wizard wants to know if the source homepage is indeed set (and to a "valid" value), not just if it /could/ be set (which is what we do now for other resources: we check for files existence).
Reporter | ||
Comment 3•13 years ago
|
||
And this is tricky because ProfileMigrator.migrate needs sourceProfiles and getResources to work synchronously, because it must open the (modal) wizard before the it returns. Otherwise, the browser window will show up.
So, it seems this cannot be made a proper resource. However, the new async function, replacing the current getter, can sure take care of the profiles issues raised in comment 1.
Comment 4•7 years ago
|
||
Bug 1434167 made this invalid
You need to log in
before you can comment on or make changes to this bug.
Description
•