Closed Bug 718295 Opened 13 years ago Closed 13 years ago

Don't rm files after zipping them into the omnijar

Categories

(Firefox Build System :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED INVALID

People

(Reporter: mounir, Assigned: mounir)

References

Details

(Whiteboard: [needs review])

Attachments

(1 file)

Attached patch Patch v1 (deleted) — Splinter Review
For some reasons I don't understand, when zipping the omnijar, we are using -m option which means the original files are actually removed when added to the zip. That is affecting the effort of fast packaging and that seems useless because we can safely assume that files will be re-generated if required, we don't have to delete them for that.
Attachment #588741 - Flags: review?(khuey)
Comment on attachment 588741 [details] [diff] [review] Patch v1 The files are removed from dist/$APP, not dist/bin, so it doesn't make anything uselessly regenerated. Moreover, even removing from dist/bin doesn't change much, since files are only regenerated when they are not in $objdir/$srcdir. Removing from dist/$APP is also necessary for the files *not* to be in the final package. In the case of the omnijar, this means you end up with chrome and other stuff, on android, in both the apk and the omni.ja inside the apk. In the case of jsloader resources, it's useful so that if a js module is removed, its cache version doesn't end up in the package.
Attachment #588741 - Flags: review?(khuey) → review-
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: