Closed
Bug 718634
Opened 13 years ago
Closed 13 years ago
Move CanSkip* to nsCycleCollectionParticipant
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: smaug, Assigned: smaug)
References
Details
Attachments
(1 file)
(deleted),
patch
|
mccr8
:
review+
|
Details | Diff | Splinter Review |
hg diff created a bit strange output. I moved CanSkip* methods, not the other methods.
And I changed the ctors.
The patch adds CanSkipThis only to NoteRoot, but it could be added perhaps
also elsewhere. But that can be done when needed.
This patch was required to skip nsJSEventListeners
Attachment #589176 -
Flags: review?(continuation)
Comment 1•13 years ago
|
||
Comment on attachment 589176 [details] [diff] [review]
patch
Looks good.
Yeah, HG's default diff does not handle moving chunks of code around very well. There's some way to set it so you can manually use a different diff that will produce better results in these situations, but I don't remember how to do that off hand.
Attachment #589176 -
Flags: review?(continuation) → review+
Updated•13 years ago
|
OS: Linux → All
Hardware: x86_64 → All
Assignee | ||
Comment 2•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•