See testcase, steps to reproduce: - Focus input, type something so the form autocomplete popup comes up. Expected result: - Form autocomplete popup should appear under the text input Actual result: - Form autocomplete popup appears over text input It seems as if the form autocomplete popup positioning code doesn't take into account when a page is inside an (i)frame. You can see that with the iframes at the right/bottom of the page. In those cases, the form autcomplete popup still appears at the top left of the screen, instead just under or over the text input.

Comment on attachment 593460 [details] [diff] [review] (1/2) Minor cleanup This looks good to me.

Comment on attachment 593461 [details] [diff] [review] (2/2) Fix rect being used This looks good to me.

https://hg.mozilla.org/integration/mozilla-inbound/rev/b4de07959f1b https://hg.mozilla.org/integration/mozilla-inbound/rev/2e5c15acd1cd

https://hg.mozilla.org/mozilla-central/rev/b4de07959f1b https://hg.mozilla.org/mozilla-central/rev/2e5c15acd1cd

Comment on attachment 593460 [details] [diff] [review] (1/2) Minor cleanup [Approval Request Comment] Regression caused by (bug #): none User impact if declined: none Testing completed (on m-c, etc.): on-mc Risk to taking this patch (and alternatives if risky): this one is just cleanup, so low-risk. if we don't take it future patches may not apply cleanly. mobile-only. String changes made by this patch:

Comment on attachment 593461 [details] [diff] [review] (2/2) Fix rect being used [Approval Request Comment] Regression caused by (bug #): none User impact if declined: the autocomplete box for input elements gets incorrectly positioned when the input element is inside a frame Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): possibility of other regressions in positioning of autocomplete box. mobile-only String changes made by this patch: none

Comment on attachment 593460 [details] [diff] [review] (1/2) Minor cleanup Mobile-only. Low-risk

Comment on attachment 593461 [details] [diff] [review] (2/2) Fix rect being used Mobile-only. Low-risk

Looks like blassey landed these on aurora: https://hg.mozilla.org/releases/mozilla-aurora/rev/0222e009ec90 https://hg.mozilla.org/releases/mozilla-aurora/rev/5588d4b9d379 and beta: https://hg.mozilla.org/releases/mozilla-beta/rev/c57273eba0d8 https://hg.mozilla.org/releases/mozilla-beta/rev/0719ba545a70

Verified Fixed on: Firefox Beta 11 (20120207195459) Firefox Aurora 12.0a2 (2012-02-07) Firefox Nightly 13.0a1 (2012-02-08) Device: Samsung Galaxy SII, Android 2.3.4