Closed
Bug 71884
Opened 24 years ago
Closed 24 years ago
Native Get Plugin dialog must not be modal
Categories
(Core Graveyard :: Plug-ins, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla0.9
People
(Reporter: BenB, Assigned: serhunt)
Details
Attachments
(2 files)
(deleted),
text/html
|
Details | |
(deleted),
patch
|
Details | Diff | Splinter Review |
Reproduce: 1. Open a page with Flash content, e.g. <http://www.heise.de/tp/deutsch/inhalt/te/8450/1.html>. 2. Try to scroll any Mozilla window. Actual result: Impossible. A native, app-modal dialog* appears, which blocks all input. Making this worse, the dialog is not necessarily immediately visible, depending on the window manager configuration (it seems to be a top-level window, which will appear at a free space on my system, not a child window, which would appear centered on the parent window). *Content: 'The page contains content of an unknown type (application/x-shockwave-flash). Do you want to download an appropriate plugin?' Expected result: A non-intriguing window, with an option to remember the decision (IIRC, there is already a bug about the "remember" option). Additional Comments: - This is on Linux, I don't know about non-Unix platforms. - On the first occurances, I thought, Mozilla freezed. - This bug is very visible, since many pages contain Flash and other non-standard content, and we cannot assume that the user has appropriate plugins. Thus, severity Major.
Reporter | ||
Updated•24 years ago
|
Keywords: mozilla0.9
Comment 2•24 years ago
|
||
the patch for http://bugzilla.mozilla.org/show_bug.cgi?id=67879 fixes this one so feel free to mark this as a dup of 67879
*** This bug has been marked as a duplicate of 67879 ***
Status: NEW → RESOLVED
Closed: 24 years ago
Resolution: --- → DUPLICATE
Reporter | ||
Comment 5•24 years ago
|
||
NO, in this case, please verify only, if you tested it and saw this being fixed. Dup bugs are unfortunately not always checked during verification of bugs.
Status: VERIFIED → REOPENED
Resolution: DUPLICATE → ---
I am not reclosing this as a dup but rather leave it open and change the platform to Windows. 67879 will address Unix issues. Unpleasant experience with this dialog being modal shows up if you have it poped up on a page with redirection. If this is the only Navigator window open the modal dialog message loop blocks all the events including network activity, so redirection never happens. If there is another window open everything looks alive but after the redirection occurs dialog doesn't go away while loses its parent, making it impossible to dismiss it or access the Navigator window. By the way, we already changed it to modeless in the latest editions of 4.7x Serge, would you please attach the test case and steps to reproduce the problem?
OS: Linux → Windows NT
Summary: Plugin-Downloader dialog must not be modal → Native Get Plugin dialog must not be modal
Comment 8•24 years ago
|
||
Comment 9•24 years ago
|
||
to reproduce: open more than one mozilla windows, click on attached test case click on puzzle icon to pop up nullplugin's dialog, while dialog is up try to click on any urls link in different window, repeat those steps several times, eventually we'll crash. to get 90% repro, just delete these 2 reg keys before testing HKEY_CURRENT_USER\Software\Netscape\Netscape Navigator\Default Plugin\application/x-gzp HKEY_CURRENT_USER\Software\Netscape\Netscape Navigator\Default Plugin\application/x-g-zp
Assignee | ||
Comment 10•24 years ago
|
||
Assignee | ||
Comment 13•24 years ago
|
||
checked in
Status: REOPENED → RESOLVED
Closed: 24 years ago → 24 years ago
Resolution: --- → FIXED
Comment 14•24 years ago
|
||
verified on win 0416 build. Get Plugin dialog is non modal now.
Status: RESOLVED → VERIFIED
Comment 15•24 years ago
|
||
I think by some mistake (because my local tree has it in) the next code is missing from the patch:( ================================================================= RCA file: /cvsroot/mozilla/modules/plugin/default/windows/plugin.cpp,v retrieving revision 1.3 die -u -r1.3 plugin.cpp --- plugin.cpp 2001/03/30 23:56:38 1.3 +++ plugin.cpp 2001/04/17 21:03:58 @@ -428,8 +428,11 @@ if((m_szPageURL != NULL) || (m_szFileURL != NULL) || !m_bJavaScript) { - CreateDialogParam(m_hInst, MAKEINTRESOURCE(IDD_PLUGIN_DOWNLOAD), m_hWnd, + if(m_hWndDialog == NULL) + { + CreateDialogParam(m_hInst, MAKEINTRESOURCE(IDD_PLUGIN_DOWNLOAD), m_hWnd, (DLGPROC)GetPluginDialogProc, (LPARAM)this); + } } } -- without this check we do open several dialogs for the same mimetype, which is not right, but the worst part is the crash. To test: click on the first attachment, click several times on the same puzzle icon, several dialogs should popup, wait for page reload... see the crash.
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•