Closed Bug 7190 Opened 25 years ago Closed 25 years ago

Every plugin loading - needed?

Categories

(SeaMonkey :: Build Config, defect, P3)

x86
Windows 95
defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: leger, Assigned: serhunt)

Details

(Whiteboard: [Perf])

TO DO for Performance: Why are we loading every pluggin in the pluggin directory during loading? Do we need to do this?
Whiteboard: [Perf]
Target Milestone: M7
Assignee: cyeh → amusil
umm...i don't think this belongs to me. re-assigning to amusil.
Blocks: 7251
This is nothing different from what 4.5 and previous browsers do when initializing plugins, and this should take no longer than a few seconds on most systems. This is currently being done in the init of LiveConnect. Patrick - can you make some comments as to what it would take to delay this action?
QA Contact: cyeh → paulmac
Reassigning Plugin bugs to Andrei
Summary: Every pluggin loading - needed? → Every plugin loading - needed?
Status: NEW → ASSIGNED
On Windows we do not load plugins in terms of LoadLibrary, but rather read plugin info from the dll's version stamps. That's needed for the plugin list initialization.
okay, i've done the stupid thing and created a directory named "plugins" in the main .exe directory for every platform. this should prevent the search for 3.0 and 4.0 plugins and prevent the spurious load attempts. there should be a second pass fix that addresses this problem in a more graceful manner.
The original report was about loading all plugins during startup, which is unnecessary on Windows. It was not like this in pre-5 world.
I moved actual dll loading to the point where it is only needed, and compared loading time in both cases in series of ten startups in each case. I tested this on 200 MHz machine with debug build and following plugins in the plugins dir: np32dsw, npaudio, npavi32, npbeatsp, npdsplay, npnul32, nppdf32, nppl3260, npqtw32, npswf32, npvcal32, npwinless. The time needed for gathering plugin info only was: when plugins loaded -- 2637 msec average with 380 msec of standard deviation, when plugins not loaded -- 379 msec average with 39 msec of standard deviation. Gain is more than two seconds with twelve plugins.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
paulmac, can you mark Verified?
I will when I verify it, I promise :-)
Status: RESOLVED → VERIFIED
Okay, I don't have a great way of testing this, but I see no difference in load time with or without a plug-ins directory, leading me to believe that plug-ins are not being loaded at start-up. Marking verified.
No longer blocks: 7251
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.