Closed
Bug 719253
Opened 13 years ago
Closed 13 years ago
Fennec cannot init EGL libs due to wrong library name
Categories
(Core :: Graphics, defect)
Tracking
()
RESOLVED
FIXED
mozilla12
| Tracking | Status | |
|---|---|---|
| firefox11 | --- | fixed |
People
(Reporter: romaxa, Assigned: romaxa)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
glandium
:
review+
blassey
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
In bug 716825
not only full path to libraries was removed, but also library names changed too
for example:
-#define EGL_LIB "/usr/lib/libEGL.so"
-#define GLES2_LIB "/usr/lib/libGLESv2.so"
+#define EGL_LIB "libEGL.so.1"
+#define GLES2_LIB "libGLESv2.so.2"
Not sure home many non-android egl based systems we have, but most of them similar to android have only libEGL.so, and without api suffix.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #589692 -
Flags: review?(mh+mozilla)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 589692 [details] [diff] [review]
Switch back to old library names
Review of attachment 589692 [details] [diff] [review]:
-----------------------------------------------------------------
See bug 716825 comment 7
Attachment #589692 -
Flags: review?(mh+mozilla) → review-
|
|
Assignee | |
Comment 3•13 years ago
|
||
Assignee: nobody → romaxa
Attachment #589692 -
Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #590125 -
Flags: review?(mh+mozilla)
|
|
||
Comment 4•13 years ago
|
||
Comment on attachment 590125 [details] [diff] [review]
Lookup for EGL library
Review of attachment 590125 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/gl/GLContextProviderEGL.cpp
@@ +385,5 @@
> #endif
>
> if (!mEGLLibrary) {
> mEGLLibrary = PR_LoadLibrary(EGL_LIB);
> +#if defined(XP_UNIX)
It's probably too broad, but it doesn't hurt.
Attachment #590125 -
Flags: review?(mh+mozilla) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 5•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla12
|
|
||
Comment 6•13 years ago
|
||
Comment on attachment 590125 [details] [diff] [review]
Lookup for EGL library
[Approval Request Comment]
Regression caused by bug 716825, which is a dependency of bug 683127.
Attachment #590125 -
Flags: approval-mozilla-aurora?
|
||
Updated•13 years ago
|
Attachment #590125 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
||
Comment 7•13 years ago
|
||
status-firefox11:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•